From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933497AbcA0P2n (ORCPT ); Wed, 27 Jan 2016 10:28:43 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34587 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932740AbcA0P2i (ORCPT ); Wed, 27 Jan 2016 10:28:38 -0500 Date: Wed, 27 Jan 2016 16:28:35 +0100 From: Michal Hocko To: Naoya Horiguchi Cc: Andrew Morton , Minchan Kim , "Kirill A. Shutemov" , Jason Baron , Chen Gong , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Naoya Horiguchi Subject: Re: [PATCH v1] mm/madvise: update comment on sys_madvise() Message-ID: <20160127152835.GD13956@dhcp22.suse.cz> References: <1453857865-13650-1-git-send-email-n-horiguchi@ah.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453857865-13650-1-git-send-email-n-horiguchi@ah.jp.nec.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 27-01-16 10:24:25, Naoya Horiguchi wrote: > Some new MADV_* advices are not documented in sys_madvise() comment. > So let's update it. > > Signed-off-by: Naoya Horiguchi Other than few suggestions below Acked-by: Michal Hocko > --- > mm/madvise.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git v4.4-mmotm-2016-01-20-16-10/mm/madvise.c v4.4-mmotm-2016-01-20-16-10_patched/mm/madvise.c > index 6a77114..c897b15 100644 > --- v4.4-mmotm-2016-01-20-16-10/mm/madvise.c > +++ v4.4-mmotm-2016-01-20-16-10_patched/mm/madvise.c > @@ -639,14 +639,26 @@ madvise_behavior_valid(int behavior) > * some pages ahead. > * MADV_DONTNEED - the application is finished with the given range, > * so the kernel can free resources associated with it. > + * MADV_FREE - the application marks pages in the given range as lasyfree, s@lasyfree@lazy free@ > + * where actual purges are postponed until memory pressure happens. > * MADV_REMOVE - the application wants to free up the given range of > * pages and associated backing store. > * MADV_DONTFORK - omit this area from child's address space when forking: > * typically, to avoid COWing pages pinned by get_user_pages(). > * MADV_DOFORK - cancel MADV_DONTFORK: no longer omit this area when forking. > + * MADV_HWPOISON - trigger memory error handler as if the given memory range > + * were corrupted by unrecoverable hardware memory failure. > + * MADV_SOFT_OFFLINE - try to soft-offline the given range of memory. > * MADV_MERGEABLE - the application recommends that KSM try to merge pages in > * this area with pages of identical content from other such areas. > * MADV_UNMERGEABLE- cancel MADV_MERGEABLE: no longer merge pages with others. > + * MADV_HUGEPAGE - the application wants to allocate transparent hugepages to > + * load the content of the given memory range. I guess that a slightly different wording would be better: application wants to back the given range by transparent huge pages in the future. Existing pages might be coalesced and new pages might be allocated as THP. > + * MADV_NOHUGEPAGE - cancel MADV_HUGEPAGE: no longer allocate transparent > + * hugepages. Mark the given range as not worth being backed by transparent huge pages so neither existing pages will be coalesced into THP nor new pages will be allocated as THP. > + * MADV_DONTDUMP - the application wants to prevent pages in the given range > + * from being included in its core dump. > + * MADV_DODUMP - cancel MADV_DONTDUMP: no longer exclude from core dump. > * > * return values: > * zero - success > -- > 2.7.0 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Michal Hocko SUSE Labs