From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934011AbcA0SxV (ORCPT ); Wed, 27 Jan 2016 13:53:21 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:55122 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933452AbcA0SxE (ORCPT ); Wed, 27 Jan 2016 13:53:04 -0500 Date: Wed, 27 Jan 2016 13:52:18 -0500 From: Johannes Weiner To: Vladimir Davydov Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: do not clear SHRINKER_NUMA_AWARE if nr_node_ids == 1 Message-ID: <20160127185218.GB31360@cmpxchg.org> References: <1453913242-26722-1-git-send-email-vdavydov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453913242-26722-1-git-send-email-vdavydov@virtuozzo.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2016 at 07:47:22PM +0300, Vladimir Davydov wrote: > Currently, on shrinker registration we clear SHRINKER_NUMA_AWARE if > there's the only NUMA node present. The comment states that this will > allow us to save some small loop time later. It used to be true when > this code was added (see commit 1d3d4437eae1b ("vmscan: per-node > deferred work")), but since commit 6b4f7799c6a57 ("mm: vmscan: invoke > slab shrinkers from shrink_zone()") it doesn't make any difference. > Anyway, running on non-NUMA machine shouldn't make a shrinker NUMA > unaware, so zap this hunk. > > Signed-off-by: Vladimir Davydov Acked-by: Johannes Weiner