From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934204AbcA0R4p (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Jan 2016 12:56:45 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57858 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932953AbcA0R4n (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Jan 2016 12:56:43 -0500
Date: Wed, 27 Jan 2016 19:56:37 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        Davidlohr Bueso <dbueso@suse.de>, "H. Peter Anvin" <hpa@zytor.com>,
        virtualization <virtualization@lists.linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@amacapital.net>,
        Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
        Andrey Konovalov <andreyknvl@google.com>, Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH v4 5/5] x86: drop mfence in favor of lock+addl
Message-ID: <20160127195314-mutt-send-email-mst@redhat.com>
References: <1453904765-11073-1-git-send-email-mst@redhat.com>
 <1453904765-11073-6-git-send-email-mst@redhat.com>
 <CA+55aFzcDiKjz8yzRf9ET7Qc-qeNFP5bO0qW7o2cB9G9=yXHng@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFzcDiKjz8yzRf9ET7Qc-qeNFP5bO0qW7o2cB9G9=yXHng@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 27, 2016 at 09:37:45AM -0800, Linus Torvalds wrote:
> On Wed, Jan 27, 2016 at 7:10 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > -#define __smp_mb()     mb()
> > +#define __smp_mb()     asm volatile("lock; addl $0,-4(%%esp)" ::: "memory", "cc")
> 
> So this doesn't look right for x86-64. Using %esp rather than %rsp.
> How did that even work for you?
> 
>                 Linus

Oops, didn't test this version properly.
Pls disregard, I'll repost after some proper testing.

-- 
MST