From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967563AbcA1Liz (ORCPT ); Thu, 28 Jan 2016 06:38:55 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50477 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967433AbcA1Liv (ORCPT ); Thu, 28 Jan 2016 06:38:51 -0500 Date: Thu, 28 Jan 2016 11:38:40 +0000 From: Mark Brown To: Henry Chen Cc: John Crispin , Liam Girdwood , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Chen Zhong , linux-arm-kernel@lists.infradead.org Message-ID: <20160128113840.GA6078@sirena.org.uk> References: <1453896059-44589-1-git-send-email-blogic@openwrt.org> <1453896059-44589-2-git-send-email-blogic@openwrt.org> <20160127144105.GQ6042@sirena.org.uk> <1453965401.19407.18.camel@mtksdaap41> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline In-Reply-To: <1453965401.19407.18.camel@mtksdaap41> X-Cookie: Be careful! UGLY strikes 9 out of 10! User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 28, 2016 at 03:16:41PM +0800, Henry Chen wrote: > On Wed, 2016-01-27 at 14:41 +0000, Mark Brown wrote: > > No, drivers should *never* enable things that weren't explictly enabled > > by the machine constraints. This misses the whole point of having > > constraints. They are there so that the system integrator can enable > > the functionality that is safe on a given board. =20 > Okay..the constrains should be define on device tree. > But which optional properties was suitable to fill on device tree if cons= umers want to call > regulator_set_mode directly ? > I have check the of_regulator.c and not found the suitable property name = which can set valid_modes_mask & valid_ops_mask. If you need to change the mode at runtime you will need to develop a binding for that, there isn't one at present. --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWqf26AAoJECTWi3JdVIfQE/gH/04puRWHiekNaA3j9V8AHaT+ zVmzu9a9A3uFxrqEBcLiFbxwZ1C8gelB7PaQFR/L/Tusmmp4xlQYEfSfzabppDXc GJw7eGQAsxjlt223EjkCi62DNJXenXzkVqqf8u1jGh1PXHN+S7C5sr99n9LbI9jp NEp049vpKWVymJy0iw8T7YOHWQRRtYmy7QswsII//4u3gxDJ8tLCLmHZN4ymGHW0 puvnSQYYeLdGRgFMOTnuKU+6uvQ4EHCC5CrcQKLWxUbrkPLkyPnzjmI9nbWmeVUu LUkFxf3O6FB2anDCHR96rgKGsPfJW+ZlVgreKyxJj8xvqNixomGGZ1ZRbQS5fGs= =/asa -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh--