From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967707AbcA1Pzx (ORCPT ); Thu, 28 Jan 2016 10:55:53 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:58900 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967620AbcA1Pzp (ORCPT ); Thu, 28 Jan 2016 10:55:45 -0500 Date: Thu, 28 Jan 2016 15:54:44 +0000 From: One Thousand Gnomes To: Ulf Hansson Cc: Shawn Lin , Russell King - ARM Linux , Adrian Hunter , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-mmc , "linux-kernel@vger.kernel.org" Subject: Re: [RFC PATCH 0/21] Totally remove SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk Message-ID: <20160128155444.04d72b47@lxorguk.ukuu.org.uk> In-Reply-To: References: <1453871155-3283-1-git-send-email-shawn.lin@rock-chips.com> <56A8BF22.8010509@intel.com> <20160127132348.GY10826@n2100.arm.linux.org.uk> <56A97A27.4000501@rock-chips.com> <20160128112946.4d750fae@lxorguk.ukuu.org.uk> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Jan 2016 16:03:34 +0100 Ulf Hansson wrote: > [...] > > > > >> > of it's bad code structure. Therefore I have taken a quite simple > >> > approach by rejecting new callbacks and quirks, in a way to prevent it > >> > from being worse. > > > > Which merely guarantees that the problem gets worse, because everyone > > just puts their SD patches into Android trees instead and then when that > > device is needed in Linux proper the crap hits the fan or people write > > uglier and more hideous hacks buried elsewhere. > > > > Eventually something gives way, and it will always be the maintainer, > > because everyone needs to get their devices supported. You can guide new > > callbacks in constructive ways but not stop them. > > Well, I did stop them at least temporary. I always describe it as "putting a cork in the sewerage pipe". It might stop it for a bit but a) you don't want to be too close when it breaks b) it's not good what happens further up the pipe > > Although, I have been telling people *why* and also trying to give > some guidelines of how I wanted this to move forward. > > I understand some become frustrated from getting patches nacked like this. > > In principle I have requested them to help evolving sdhci in a new and > better direction, instead of adding yet more hacks. That of course > requires a deeper understanding of both the mmc core, but also sdhci > in general. > > [...] > > Also, thanks for sharing your experience in this field. You made some > good points! I'm happy to help try and sort the code out. Not maintain it - my knowledge of the intricacies of SDHCI is not good enough. Alan