From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161307AbcA1P4T (ORCPT ); Thu, 28 Jan 2016 10:56:19 -0500 Received: from mx2.suse.de ([195.135.220.15]:50105 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161154AbcA1P4Q (ORCPT ); Thu, 28 Jan 2016 10:56:16 -0500 Date: Thu, 28 Jan 2016 16:56:13 +0100 From: Olaf Hering To: "K. Y. Srinivasan" Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, ohering@suse.com, jbottomley@parallels.com, hch@infradead.org, linux-scsi@vger.kernel.org, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, martin.petersen@oracle.com, hare@suse.de Subject: Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot Message-ID: <20160128155613.GA12447@gmail.com> References: <1453966147-10568-1-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1453966147-10568-1-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.24 (6551) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, K. Y. Srinivasan wrote: > + depends on SCSI_FC_ATTRS I think 'depends' instead of 'select' will cause HYPERV_STORAGE to disapepar during make oldconfig if SCSI_FC_ATTRS was not set before. Not sure what the policy of 'depends' vs. 'select' actually is. If SCSI_FC_ATTRS is supposed to be a library kind of thing then 'select' might be the correct way. Olaf