From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755535AbcA1QJE (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Jan 2016 11:09:04 -0500
Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:58998 "EHLO
	lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752528AbcA1QJB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Jan 2016 11:09:01 -0500
Date: Thu, 28 Jan 2016 16:07:11 +0000
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: Shuah Khan <shuahkh@osg.samsung.com>, tiwai@suse.com, clemens@ladisch.de,
        hans.verkuil@cisco.com, laurent.pinchart@ideasonboard.com,
        sakari.ailus@linux.intel.com, javier@osg.samsung.com, pawel@osciak.com,
        m.szyprowski@samsung.com, kyungmin.park@samsung.com, perex@perex.cz,
        arnd@arndb.de, dan.carpenter@oracle.com, tvboxspy@gmail.com,
        crope@iki.fi, ruchandani.tina@gmail.com, corbet@lwn.net,
        chehabrafael@gmail.com, k.kozlowski@samsung.com,
        stefanr@s5r6.in-berlin.de, inki.dae@samsung.com,
        jh1009.sung@samsung.com, elfring@users.sourceforge.net,
        prabhakar.csengg@gmail.com, sw0312.kim@samsung.com,
        p.zabel@pengutronix.de, ricardo.ribalda@gmail.com,
        labbott@fedoraproject.org, pierre-louis.bossart@linux.intel.com,
        ricard.wanderlof@axis.com, julian@jusst.de, takamichiho@gmail.com,
        dominic.sacre@gmx.de, misterpib@gmail.com, daniel@zonque.org,
        gtmkramer@xs4all.nl, normalperson@yhbt.net, joe@oampo.co.uk,
        linuxbugs@vittgam.net, johan@oljud.se, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, linux-api@vger.kernel.org,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH 15/31] media: dvb-frontend invoke enable/disable_source
 handlers
Message-ID: <20160128160711.029f3faf@lxorguk.ukuu.org.uk>
In-Reply-To: <20160128135304.3daa79f1@recife.lan>
References: <cover.1452105878.git.shuahkh@osg.samsung.com>
	<1591b6cf2025fa95a13e3b7dde52aa0e0bde0bb4.1452105878.git.shuahkh@osg.samsung.com>
	<20160128135304.3daa79f1@recife.lan>
Organization: Intel Corporation
X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 28 Jan 2016 13:53:04 -0200
Mauro Carvalho Chehab <mchehab@osg.samsung.com> wrote:

> Em Wed,  6 Jan 2016 13:27:04 -0700
> Shuah Khan <shuahkh@osg.samsung.com> escreveu:
> 
> > Checking for tuner availability from frontend thread start
> > disrupts video stream. Change to check for tuner and start
> > pipeline from frontend open instead and stop pipeline from
> > frontend release.  
> 
> That's wrong, as DVB can be opened on read-only mode, where
> it won't be changing anything.
> 
> Also, I don't think POSIX allows to return an error like EBUSY
> on open:
> 	http://pubs.opengroup.org/onlinepubs/9699919799/functions/open.html

It doesn't document all the errors you may return. Quite a lot of
kernel drivers return EBUSY when they are "single open" things.

POSIX documents certain cases that *must* error and what the error code
is. It documents certain possible failures and what their error code is.
Beyond that it's up to you.

Alan