From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751884AbcA1XNX (ORCPT ); Thu, 28 Jan 2016 18:13:23 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51211 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbcA1XNU (ORCPT ); Thu, 28 Jan 2016 18:13:20 -0500 Date: Fri, 29 Jan 2016 00:13:06 +0100 From: Mark Brown To: John Crispin Cc: Liam Girdwood , Chen Zhong , Matthias Brugger , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, HenryC Chen =?utf-8?B?KOmZs+W7uuixqik=?= Message-ID: <20160128231306.GD4130@sirena.org.uk> References: <1453896059-44589-1-git-send-email-blogic@openwrt.org> <1453896059-44589-2-git-send-email-blogic@openwrt.org> <20160127144105.GQ6042@sirena.org.uk> <56AA5A5C.9080402@openwrt.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="C+ts3FVlLX8+P6JN" Content-Disposition: inline In-Reply-To: <56AA5A5C.9080402@openwrt.org> X-Cookie: NOBODY EXPECTS THE SPANISH INQUISITION! User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 109.236.131.45 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --C+ts3FVlLX8+P6JN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 28, 2016 at 07:13:48PM +0100, John Crispin wrote: > would the following two bindings be ok ? I would create patches to add them. > * regulator-allow-mode; or regulator-allow-change-mode; This seems redundant, if we have a list of valid modes presumably they can be used - same idea as with voltage setting. > * regulator-modes = ; I'm not convinced this binding makes sense, how would a user of the API (currently there are none in tree) know what the modes mean? It's a bit different when the user is supplying configuration for a specific regulator but this needs to be something that can be used by consumers. What are you actually trying to do with this? --C+ts3FVlLX8+P6JN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWqqCBAAoJECTWi3JdVIfQMygH/Avl7NgcybqAMKGmvX2F2RJI WWCIYMnclibZD+dqnbazVdOCX1PtzlfRyC+oninbi5Lbo+bpTxI2wJsCUvYayOJs 6q9dIUH3QK4kMou+ryJMNcXj34rriiq5hfcqxbM46VoIkyoRTl+Fn6EQMYtmZr3n 4vFGpKOg+Jb0WlUR+VoyEFTQVhgcGEfwnZK0BPj13tj/kuOGywlZkE8Qq9QV25E+ TZosBE02lVE8jnVn8dugz05t1TsBO/LjXe2D7cHWR+rVQULILRYL/bAbko3VGDhg cnrnnz3mdMNmzFkv1yBjao5qUzuvRTOegcc3zM0KNaFQNM2EplkxzBC9mbItO0o= =K1eG -----END PGP SIGNATURE----- --C+ts3FVlLX8+P6JN--