From: Andy Gross <andy.gross@linaro.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: Andy Gross <agross@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
Rob Herring <robh+dt@kernel.org>, Rob Herring <robh@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Archit Taneja <architt@codeaurora.org>
Subject: Re: [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size
Date: Thu, 28 Jan 2016 22:38:55 -0600 [thread overview]
Message-ID: <20160129043855.GA4608@hector.attlocal.net> (raw)
In-Reply-To: <56697BA9.5050805@linaro.org>
On Thu, Dec 10, 2015 at 03:18:33PM +0200, Stanimir Varbanov wrote:
<snip>
> >>> This is just using the #define. That is ok, but if you use this instead of the
> >>> BAM_P_FIFO_SIZES then you need to fix your comment. Or actually use the
> >>> register value.... otherwise looks fine.
> >>
> >> I did not follow your comment, but the intension of the patch is to set
> >> the proper FIFO size in BAM_P_FIFO_SIZES register, i.e. 32K - 8.
> >
> > Sorry, I mixed up the usage and was thinking there was something you read out
> > that told you the size. That's not how it works, unfortunately. The
> > MAX_DATA_SIZE is fine, but the name is a little misleading. Perhaps just
> > BAM_FIFO_SIZE?
>
> OK I can rename BAM_MAX_DATA_SIZE to BAM_FIFO_SIZE, and use it when
> setting BAM_P_FIFO_SIZES register. Is that fine to you?
Yes that's fine with me.
next prev parent reply other threads:[~2016-01-29 4:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 9:14 [PATCH 0/4] bam dma fixes and one dt extension Stanimir Varbanov
2015-12-01 9:14 ` [PATCH 1/4] dmaengine: qcom_bam_dma: fix dma free memory on remove Stanimir Varbanov
2015-12-01 9:14 ` [PATCH 2/4] dmaengine: qcom_bam_dma: clear BAM interrupt only if it is rised Stanimir Varbanov
2015-12-01 10:29 ` Arnd Bergmann
2015-12-02 12:56 ` Stanimir Varbanov
2015-12-02 13:05 ` Arnd Bergmann
2015-12-02 16:47 ` Stanimir Varbanov
2015-12-01 17:28 ` Andy Gross
2015-12-01 9:14 ` [PATCH 3/4] dmaengine: qcom_bam_dma: use correct pipe FIFO size Stanimir Varbanov
2015-12-01 10:28 ` Arnd Bergmann
2015-12-01 17:25 ` Andy Gross
2015-12-01 20:22 ` Arnd Bergmann
2015-12-01 17:23 ` Andy Gross
2015-12-02 16:44 ` Stanimir Varbanov
2015-12-02 17:22 ` Andy Gross
2015-12-10 13:18 ` Stanimir Varbanov
2016-01-29 4:38 ` Andy Gross [this message]
2015-12-01 9:14 ` [PATCH 4/4] dmaengine: qcom_bam_dma: add controlled remotely dt property Stanimir Varbanov
2015-12-01 17:30 ` Andy Gross
2016-04-05 21:33 ` [PATCH 0/4] bam dma fixes and one dt extension Andy Gross
2016-04-05 23:06 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129043855.GA4608@hector.attlocal.net \
--to=andy.gross@linaro.org \
--cc=agross@codeaurora.org \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome