From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752893AbcA2Haq (ORCPT ); Fri, 29 Jan 2016 02:30:46 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:59130 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752520AbcA2Hap (ORCPT ); Fri, 29 Jan 2016 02:30:45 -0500 Date: Fri, 29 Jan 2016 08:30:42 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Arnd Bergmann Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alessandro Rubini Subject: Re: [PATCH] pinctrl: nomadik: hide unused functions Message-ID: <20160129073042.GL13664@pengutronix.de> References: <1453737557-1960171-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1453737557-1960171-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Arnd, On Mon, Jan 25, 2016 at 04:59:09PM +0100, Arnd Bergmann wrote: > The nomadik pinctrl driver has two functions that are only used > for debugfs output and are otherwise unused: > > drivers/pinctrl/nomadik/pinctrl-abx500.c:194:12: error: 'abx500_get_pull_updown' defined but not used > drivers/pinctrl/nomadik/pinctrl-abx500.c:471:12: error: 'abx500_get_mode' defined but not used > > This makes the function definitions conditional to avoid the > harmless warnings. > [...] > +#ifdef CONFIG_DEBUG_FS > static int abx500_get_pull_updown(struct abx500_pinctrl *pct, int offset, > enum abx500_gpio_pull_updown *pull_updown) an alternative is to mark the functions with __maybe_unused. I just noticed that Documentation/CodingStyle even mandates to use that instead of cpp stuff. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |