From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756248AbcA2OiG (ORCPT ); Fri, 29 Jan 2016 09:38:06 -0500 Received: from smtprelay0003.hostedemail.com ([216.40.44.3]:43649 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752403AbcA2OiE (ORCPT ); Fri, 29 Jan 2016 09:38:04 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3872:3874:5007:6261:7875:10004:10400:10848:10967:11026:11232:11658:11914:12296:12438:12517:12519:12555:12740:13069:13311:13357:14096:14097:14659:21080:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:11,LUA_SUMMARY:none X-HE-Tag: steel66_29064f4ebc459 X-Filterd-Recvd-Size: 2339 Date: Fri, 29 Jan 2016 09:38:00 -0500 From: Steven Rostedt To: Jessica Yu Cc: Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Miroslav Benes , Ingo Molnar , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ftrace: Adjust priority of ftrace module notifier Message-ID: <20160129093800.6c739e40@gandalf.local.home> In-Reply-To: <1454049827-3726-3-git-send-email-jeyu@redhat.com> References: <1454049827-3726-1-git-send-email-jeyu@redhat.com> <1454049827-3726-3-git-send-email-jeyu@redhat.com> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jan 2016 01:43:47 -0500 Jessica Yu wrote: > --- > kernel/trace/ftrace.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index eca592f..bdd7bfc 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -5067,7 +5067,12 @@ static int ftrace_module_notify(struct notifier_block *self, > > struct notifier_block ftrace_module_nb = { > .notifier_call = ftrace_module_notify, > - .priority = INT_MIN, /* Run after anything that can remove kprobes */ > + /* > + * Run after anything that can remove kprobes and > + * after livepatch's going notifier, but run before > + * livepatch's coming notifier. > + */ > + .priority = INT_MIN+1, > }; > > void __init ftrace_init(void) Actually, I rather break up the ftrace notifiers into two different notifiers. One for coming and one for going (I use to have that before hard coding the module updates in the module code). Have the coming notifier be INT_MAX, where it runs before everything else (which it should, as tracing should be enabled then). And have the module going to stay INT_MIN to run after everything. -- Steve