From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933053AbcA2UKf (ORCPT ); Fri, 29 Jan 2016 15:10:35 -0500 Received: from smtprelay0143.hostedemail.com ([216.40.44.143]:59335 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752408AbcA2UKb (ORCPT ); Fri, 29 Jan 2016 15:10:31 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3870:3874:4321:5007:6261:7875:10004:10400:10450:10455:10848:10967:11026:11232:11473:11658:11914:12296:12438:12517:12519:12555:12740:13069:13311:13357:14096:14097:14659:19904:19999:21067:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: cake27_215f274f47d00 X-Filterd-Recvd-Size: 2367 Date: Fri, 29 Jan 2016 15:10:28 -0500 From: Steven Rostedt To: Jessica Yu Cc: Josh Poimboeuf , Miroslav Benes , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Ingo Molnar , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: livepatch: Implement separate coming and going module notifiers Message-ID: <20160129151028.11d26779@gandalf.local.home> In-Reply-To: <20160129150931.3a6b734e@gandalf.local.home> References: <1454049827-3726-1-git-send-email-jeyu@redhat.com> <1454049827-3726-2-git-send-email-jeyu@redhat.com> <20160129173010.GA19101@treble.redhat.com> <20160129200451.GB14026@packer-debian-8-amd64.digitalocean.com> <20160129150931.3a6b734e@gandalf.local.home> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jan 2016 15:09:31 -0500 Steven Rostedt wrote: > On Fri, 29 Jan 2016 15:04:51 -0500 > Jessica Yu wrote: > > > >diff --git a/kernel/module.c b/kernel/module.c > > >index 8358f46..aeabd81 100644 > > >--- a/kernel/module.c > > >+++ b/kernel/module.c > > >@@ -3371,6 +3371,13 @@ static int complete_formation(struct module *mod, struct load_info *info) > > > mod->state = MODULE_STATE_COMING; > > > mutex_unlock(&module_mutex); > > > > > >+ ftrace_module_enable(mod); > > >+ err = klp_module_enable(mod); > > >+ if (err) { > > >+ ftrace_release_mod(mod); > > >+ return err; > > >+ } > > > > If we go this route, should we should print a big warning ("Livepatch > > couldn't patch loading module X") instead of aborting the module load > > completely? > > If anything, that should be done in klp_module_enable() not in the > module code. And I take that back. The module wont load. The user will notice that before any console warning. Thus no warning needed. -- Steve