From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756564AbcA2QZp (ORCPT ); Fri, 29 Jan 2016 11:25:45 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:32999 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756350AbcA2QZd (ORCPT ); Fri, 29 Jan 2016 11:25:33 -0500 Date: Fri, 29 Jan 2016 16:25:29 +0000 From: Matt Fleming To: Sai Praneeth Prakhya Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Neri , Ravi Shankar , Borislav Petkov Subject: Re: [PATCH] x86/mm/pageattr: Use _PAGE_GLOBAL bit for EFI page table mappings Message-ID: <20160129162529.GE2611@codeblueprint.co.uk> References: <1453919696-13096-1-git-send-email-sai.praneeth.prakhya@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453919696-13096-1-git-send-email-sai.praneeth.prakhya@intel.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Jan, at 10:34:56AM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > Since EFI page tables can be treated as kernel page tables they should > be global. All the other page mapping functions in pageattr.c set the > _PAGE_GLOBAL bit and we want to avoid inconsistencies when we map a page > in the EFI code paths, for example when that page is split in > __split_large_page(), etc. It also makes it easier to validate that the > EFI region mappings have the correct attributes because there are fewer > differences compared with regular kernel mappings. > > Cc: Ricardo Neri > Cc: Ravi Shankar > Cc: Borislav Petkov > Cc: Matt Fleming > Signed-off-by: Sai Praneeth Prakhya > --- > arch/x86/mm/pageattr.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Reducing any differences between the EFI mapping and regular kernel mapping code in pageattr.c is a plus. Thanks Sai, applied.