From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932884AbcA2Usi (ORCPT ); Fri, 29 Jan 2016 15:48:38 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:57296 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756697AbcA2Ush (ORCPT ); Fri, 29 Jan 2016 15:48:37 -0500 Date: Fri, 29 Jan 2016 13:48:27 -0700 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: fix control area resource mapping Message-ID: <20160129204826.GA30177@obsidianresearch.com> References: <1454051639-15961-1-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454051639-15961-1-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2016 at 11:13:59PM -0800, Jarkko Sakkinen wrote: > - struct resource tmp = {}; > - > - tmp.start = start; > - tmp.end = start + size - 1; > - tmp.flags = IORESOURCE_MEM; > + struct resource new_res = { > + .start = start, > + .end = size - 1, That isn't right. Jason