From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756742AbcA3A6G (ORCPT ); Fri, 29 Jan 2016 19:58:06 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37365 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755995AbcA3A6B (ORCPT ); Fri, 29 Jan 2016 19:58:01 -0500 Date: Fri, 29 Jan 2016 16:58:00 -0800 From: Stephen Boyd To: LABBE Corentin Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] clk: palmas: fix a possible NULL dereference Message-ID: <20160130005759.GB4848@codeaurora.org> References: <1448455923-28670-1-git-send-email-clabbe.montjoie@gmail.com> <1448455923-28670-2-git-send-email-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448455923-28670-2-git-send-email-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25, LABBE Corentin wrote: > of_match_device could return NULL, and so cause a NULL pointer > dereference later. > Even if the probability of this case is very low, fixing it made > static analyzers happy. > > Solving this with of_device_get_match_data made also code simplier. > > Reported-by: coverity (CID 1324137) > Signed-off-by: LABBE Corentin > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project