From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754722AbcA3MUv (ORCPT ); Sat, 30 Jan 2016 07:20:51 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54040 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754021AbcA3MUs (ORCPT ); Sat, 30 Jan 2016 07:20:48 -0500 X-Sasl-enc: AtVEVx7psSlK2UoTK+SuCUCJuiGgIrB9FRPdAQW+Fatw 1454156447 Date: Sat, 30 Jan 2016 10:20:45 -0200 From: Henrique de Moraes Holschuh To: Joe Perches Cc: Eric Curtin , platform-driver-x86@vger.kernel.org, Kernel development list , Darren Hart , ibm-acpi-devel@lists.sourceforge.net Subject: Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Message-ID: <20160130122045.GA14919@khazad-dum.debian.net> References: <1453937211.10099.31.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1453937211.10099.31.camel@perches.com> X-GPG-Fingerprint1: 4096R/39CB4807 C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 X-GPG-Fingerprint2: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Jan 2016, Joe Perches wrote: > On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote: > > Message gets logged on machines that are well supported. > > > > Signed-off-by: Eric Curtin > > --- > >  drivers/platform/x86/thinkpad_acpi.c | 1 - > >  1 file changed, 1 deletion(-) > > > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > > b/drivers/platform/x86/thinkpad_acpi.c > > index a268a7a..4eb41aa 100644 > > --- a/drivers/platform/x86/thinkpad_acpi.c > > +++ b/drivers/platform/x86/thinkpad_acpi.c > > @@ -6661,7 +6661,6 @@ static void __init > > tpacpi_detect_brightness_capabilities(void) > >                 pr_info("detected a 8-level brightness capable > > ThinkPad\n"); > >                 break; > >         default: > > -               pr_info("Unsupported brightness interface\n"); > >                 tp_features.bright_unkfw = 1; > >                 bright_maxlvl = b - 1; > >         } > > Perhaps this should be something like this instead: > --- >  drivers/platform/x86/thinkpad_acpi.c | 4 +--- >  1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index a268a7a..bd12c71 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void) >   switch (b) { >   case 16: >   bright_maxlvl = 15; > - pr_info("detected a 16-level brightness capable ThinkPad\n"); >   break; >   case 8: >   case 0: >   bright_maxlvl = 7; > - pr_info("detected a 8-level brightness capable ThinkPad\n"); >   break; >   default: > - pr_info("Unsupported brightness interface\n"); >   tp_features.bright_unkfw = 1; >   bright_maxlvl = b - 1; >   } > + pr_info("detected %u brightness levels\n", bright_maxlvl + 1); >  } This can be made pr_debug, since we're touching it... -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh