From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753412AbcA3TuI (ORCPT ); Sat, 30 Jan 2016 14:50:08 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:49707 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbcA3TuF (ORCPT ); Sat, 30 Jan 2016 14:50:05 -0500 X-Sasl-enc: b2PEmheCw5SkTUyZGvh34Z83FtkCeAp0ioL+cuicEpld 1454183401 Date: Sat, 30 Jan 2016 17:49:59 -0200 From: Henrique de Moraes Holschuh To: Eric Curtin Cc: Joe Perches , platform-driver-x86@vger.kernel.org, Kernel development list , Darren Hart , ibm-acpi-devel@lists.sourceforge.net Subject: Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" Message-ID: <20160130194958.GB2468@khazad-dum.debian.net> References: <1453937211.10099.31.camel@perches.com> <20160130122045.GA14919@khazad-dum.debian.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint1: 4096R/39CB4807 C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 X-GPG-Fingerprint2: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 30 Jan 2016, Eric Curtin wrote: > "Unsupported brightness interface" message gets logged on > machines that are well supported. > > Signed-off-by: Eric Curtin > --- > drivers/platform/x86/thinkpad_acpi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > b/drivers/platform/x86/thinkpad_acpi.c > index a268a7a..e305ab5 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -6653,18 +6653,16 @@ static void __init > tpacpi_detect_brightness_capabilities(void) > switch (b) { > case 16: > bright_maxlvl = 15; > - pr_info("detected a 16-level brightness capable ThinkPad\n"); > break; > case 8: > case 0: > bright_maxlvl = 7; > - pr_info("detected a 8-level brightness capable ThinkPad\n"); > break; > default: > - pr_info("Unsupported brightness interface\n"); > tp_features.bright_unkfw = 1; > bright_maxlvl = b - 1; > } > + pr_debug("detected %u brightness levels\n", bright_maxlvl + 1); > } > > static int __init brightness_init(struct ibm_init_struct *iibm) Acked-by: Henrique de Moraes Holschuh -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh