From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932706AbcBAN6Y (ORCPT ); Mon, 1 Feb 2016 08:58:24 -0500 Received: from mail.kernel.org ([198.145.29.136]:57317 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932183AbcBAN6X (ORCPT ); Mon, 1 Feb 2016 08:58:23 -0500 Date: Mon, 1 Feb 2016 07:58:17 -0600 From: Rob Herring To: Laxman Dewangan Cc: pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, k.kozlowski@samsung.com, Chaitanya Bandi Subject: Re: [PATCH V5 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024 Message-ID: <20160201135817.GA25324@rob-hp-laptop> References: <1453903808-29788-1-git-send-email-ldewangan@nvidia.com> <1453903808-29788-4-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453903808-29788-4-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 27, 2016 at 07:40:06PM +0530, Laxman Dewangan wrote: > MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO pins > which also act as the special function in alternate mode. Also > there is configuration like push-pull, open drain, FPS timing > etc for these pins. > > Add pincontrol driver to configure these parameters through > pincontrol APIs. > > Signed-off-by: Laxman Dewangan > Signed-off-by: Chaitanya Bandi > --- > Changes from V1: > - Cleanup code based on comment received on mfd/rtc. > - Avoid duplication on error message. > > Changes form V2: > - Run coccicheck and checkpatch in strict mode for the alignment. > - update based on api changes from core. > > Changes from V3: > - Change all sys initcall to module driver. > - change the max77620_read argument to unisgned int from u8. > > Changes from V4: > - Added DT binding document as devicetree/bindings/pinctrl/pinctrl-max77620.txt > - Detail out properties. > > .../bindings/pinctrl/pinctrl-max77620.txt | 87 +++ Acked-by: Rob Herring > drivers/pinctrl/Kconfig | 10 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/pinctrl-max77620.c | 693 +++++++++++++++++++++ > 4 files changed, 791 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-max77620.txt > create mode 100644 drivers/pinctrl/pinctrl-max77620.c