From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751565AbcBBCF3 (ORCPT ); Mon, 1 Feb 2016 21:05:29 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:18115 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750973AbcBBCF2 (ORCPT ); Mon, 1 Feb 2016 21:05:28 -0500 X-Greylist: delayed 422 seconds by postgrey-1.27 at vger.kernel.org; Mon, 01 Feb 2016 21:05:28 EST Date: Mon, 1 Feb 2016 20:58:10 -0500 From: Steven Rostedt To: Jeffrey Merkey Cc: linux-kernel@vger.kernel.org, Jason@zx2c4.com, aconole@redhat.com, akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org, nicolas.iooss_linux@m4x.org, pmladek@suse.com, tj@kernel.org Subject: Re: [PATCH v4 4/4] pr_emerg add WARN_XX() debugger options Message-ID: <20160201205810.59250879@grimm.local.home> In-Reply-To: <1454369752-20706-4-git-send-email-jeffmerkey@gmail.com> References: <1454369752-20706-1-git-send-email-jeffmerkey@gmail.com> <1454369752-20706-4-git-send-email-jeffmerkey@gmail.com> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Feb 2016 16:35:52 -0700 Jeffrey Merkey wrote: > --- > include/linux/printk.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/printk.h b/include/linux/printk.h > index 51dd6b8..dcfb270 100644 > --- a/include/linux/printk.h > +++ b/include/linux/printk.h > @@ -252,8 +252,16 @@ extern asmlinkage void dump_stack(void) __cold; > * and other debug macros are compiled out unless either DEBUG is defined > * or CONFIG_DYNAMIC_DEBUG is set. > */ > +#ifdef CONFIG_DEBUG_WARN > +#define pr_emerg(fmt, ...) \ > +({ \ > + printk(KERN_EMERG pr_fmt(fmt), ##__VA_ARGS__); \ > + BUG(); \ This look rather heavy handed for a debug feature. This will crash any kernel on a pr-emerg(), similar to a panic on warning. Not only that, for cases that cal pr_emerg() more than once, it crashes on the first instance. What about adding a condition that can be set set in /proc/sys/kernel/ A file called something like crash_on_print_emerg ? BUG_ON(crash_on_pr_emerg); -- Steve > +}) > +#else > #define pr_emerg(fmt, ...) \ > printk(KERN_EMERG pr_fmt(fmt), ##__VA_ARGS__) > +#endif > #define pr_alert(fmt, ...) \ > printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__) > #define pr_crit(fmt, ...) \