From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932451AbcBAVKe (ORCPT ); Mon, 1 Feb 2016 16:10:34 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58106 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932206AbcBAVKd (ORCPT ); Mon, 1 Feb 2016 16:10:33 -0500 Date: Mon, 1 Feb 2016 21:10:17 +0000 From: Mark Brown To: "Maciej S. Szmigiero" Cc: Fabio Estevam , "alsa-devel@alsa-project.org" , Timur Tabi , Nicolin Chen , Xiubo Li , Liam Girdwood , "linuxppc-dev@lists.ozlabs.org" , linux-kernel Message-ID: <20160201211017.GG4455@sirena.org.uk> References: <569D3800.2040801@maciej.szmigiero.name> <56AF4A9F.4060401@maciej.szmigiero.name> <56AF4ED0.7030801@maciej.szmigiero.name> <56AF8E9E.5000100@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JSkcQAAxhB1h8DcT" Content-Disposition: inline In-Reply-To: <56AF8E9E.5000100@maciej.szmigiero.name> X-Cookie: Duckies are fun! User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: fsl_ssi: remove explicit register defaults X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --JSkcQAAxhB1h8DcT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 01, 2016 at 05:58:06PM +0100, Maciej S. Szmigiero wrote: > Looks like a possible solution would be to change > regmap_raw_read() to do read using _regmap_read in > case the cache is bypassed and there is no ->read > callback defined for regmap implementation. No, that's completely broken. We can't do a raw read from a regmap that doesn't offer raw access and we shouldn't pretend to do so. If the caller is capable of substituting a register by register read the caller should take responsibility for that. --JSkcQAAxhB1h8DcT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWr8m4AAoJECTWi3JdVIfQ7Z4H/Reu/R+eh43RZfjK7y+WNdlV IkRkqAp3l86gX/zwpxxzqmWz5fjf8gG0vdENxSXUfAzylLPoLw162KD/+oW9UeD2 4tJBNzitCISauuAnZmH81llShMCV6qfhgPaZPJmygzHDwaXYGJDS0LZNejUNYK+3 /sBx+BPbIoPOewBZg1w5Mpu/rxxaiWhFGwOD2ntBUrmCgwpv6SthkV+c2CcdHT7d 78q8RwAi9lEbetsASwOFGa1J6ZSUKBA8vWHEjsggroboR+Lni6Zvl+Nq3DHnge6w ExlQ95cwLh8eZ5lwOcrI7xoZiZrV/IjquyOSl3mddq3gFOoeLMQFuuCoGcG1CY4= =8Tfw -----END PGP SIGNATURE----- --JSkcQAAxhB1h8DcT--