From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753750AbcBBBKH (ORCPT ); Mon, 1 Feb 2016 20:10:07 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:40761 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbcBBBIM (ORCPT ); Mon, 1 Feb 2016 20:08:12 -0500 Date: Mon, 1 Feb 2016 17:08:11 -0800 From: Stephen Boyd To: Masahiro Yamada Cc: linux-clk@vger.kernel.org, Michael Turquette , linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v2 11/16] clk: simplify __clk_init_parent() Message-ID: <20160202010811.GZ4848@codeaurora.org> References: <1451298191-30815-1-git-send-email-yamada.masahiro@socionext.com> <1451298191-30815-12-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451298191-30815-12-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/28, Masahiro Yamada wrote: > The translation from the index into clk_core is done by > clk_core_get_parent_by_index(). The if-block for num_parents == 1 > case is duplicating the code in the clk_core_get_parent_by_index(). > > Drop the "if (num_parents == 1)" from the special case. Instead, > set the index to zero if .get_parent() is missing. > > Signed-off-by: Masahiro Yamada > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project