From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753954AbcBBOSr (ORCPT ); Tue, 2 Feb 2016 09:18:47 -0500 Received: from mx2.parallels.com ([199.115.105.18]:47948 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbcBBOSp (ORCPT ); Tue, 2 Feb 2016 09:18:45 -0500 Date: Tue, 2 Feb 2016 17:18:25 +0300 From: Vladimir Davydov To: Johannes Weiner CC: Andrew Morton , Michal Hocko , , , , Subject: Re: [PATCH v2 1/5] mm: memcontrol: generalize locking for the page->mem_cgroup binding Message-ID: <20160202141825.GB21016@esperanza> References: <1454090047-1790-1-git-send-email-hannes@cmpxchg.org> <1454090047-1790-2-git-send-email-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1454090047-1790-2-git-send-email-hannes@cmpxchg.org> X-ClientProxiedBy: US-EXCH.sw.swsoft.com (10.255.249.47) To US-EXCH.sw.swsoft.com (10.255.249.47) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 29, 2016 at 12:54:03PM -0500, Johannes Weiner wrote: > So far the only sites that needed to exclude charge migration to > stabilize page->mem_cgroup have been per-cgroup page statistics, hence > the name mem_cgroup_begin_page_stat(). But per-cgroup thrash detection > will add another site that needs to ensure page->mem_cgroup lifetime. > > Rename these locking functions to the more generic lock_page_memcg() > and unlock_page_memcg(). Since charge migration is a cgroup1 feature > only, we might be able to delete it at some point, and these now easy > to identify locking sites along with it. > > Suggested-by: Vladimir Davydov > Signed-off-by: Johannes Weiner Acked-by: Vladimir Davydov