From: Johannes Thumshirn <jthumshirn@suse.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Borislav Petkov <bp@alien8.de>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Johannes Thumshirn <morbidrsa@gmail.com>,
Doug Thompson <dougthompson@xmission.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH] EDAC, mpc85xx: fix build warning
Date: Tue, 2 Feb 2016 15:48:03 +0100 [thread overview]
Message-ID: <20160202144803.GQ27969@c203.arch.suse.de> (raw)
In-Reply-To: <20160202143801.GA6995@roeck-us.net>
On Tue, Feb 02, 2016 at 06:38:01AM -0800, Guenter Roeck wrote:
> On Tue, Feb 02, 2016 at 12:15:45PM +0100, Borislav Petkov wrote:
> > On Tue, Feb 02, 2016 at 01:30:21PM +0530, Sudip Mukherjee wrote:
> > > We were getting build warning about:
> > > drivers/edac/mpc85xx_edac.c:1247:6: warning: unused variable 'pvr'
> > >
> > > pvr is only used if CONFIG_FSL_SOC_BOOKE was defined. Declare the
> > > variable as a local variable inside the #ifdef block.
> >
> > What's wrong with doing the simpler thing:
> >
> > ---
> > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> > index b7139c160baf..f756b6215228 100644
> > --- a/drivers/edac/mpc85xx_edac.c
> > +++ b/drivers/edac/mpc85xx_edac.c
> > @@ -1244,7 +1244,6 @@ static struct platform_driver * const drivers[] = {
> > static int __init mpc85xx_mc_init(void)
> > {
> > int res = 0;
> > - u32 pvr = 0;
> >
> Or with just adding __maybe_unused here.
I'd favour this one as well.
Just my 2c.
byte,
Johannes
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2016-02-02 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 8:00 Sudip Mukherjee
2016-02-02 11:15 ` Borislav Petkov
2016-02-02 14:38 ` Guenter Roeck
2016-02-02 14:48 ` Johannes Thumshirn [this message]
2016-02-02 14:55 ` Sudip Mukherjee
2016-02-02 15:09 ` Borislav Petkov
2016-02-02 15:13 ` Sudip Mukherjee
2016-02-02 15:15 ` Borislav Petkov
2016-02-02 15:19 ` Sudip Mukherjee
2016-02-02 14:48 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202144803.GQ27969@c203.arch.suse.de \
--to=jthumshirn@suse.de \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab@osg.samsung.com \
--cc=morbidrsa@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®