From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932755AbcBBOse (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Feb 2016 09:48:34 -0500
Received: from mail-pa0-f52.google.com ([209.85.220.52]:34371 "EHLO
	mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932478AbcBBOsb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Feb 2016 09:48:31 -0500
Date: Tue, 2 Feb 2016 20:18:18 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Johannes Thumshirn <morbidrsa@gmail.com>,
        Doug Thompson <dougthompson@xmission.com>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH] EDAC, mpc85xx: fix build warning
Message-ID: <20160202144818.GA7200@sudip-laptop>
References: <1454400021-17583-1-git-send-email-sudipm.mukherjee@gmail.com>
 <20160202111545.GC3778@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160202111545.GC3778@pd.tnic>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 02, 2016 at 12:15:45PM +0100, Borislav Petkov wrote:
> On Tue, Feb 02, 2016 at 01:30:21PM +0530, Sudip Mukherjee wrote:
> > We were getting build warning about:
> > drivers/edac/mpc85xx_edac.c:1247:6: warning: unused variable 'pvr'
> > 
> > pvr is only used if CONFIG_FSL_SOC_BOOKE was defined. Declare the
> > variable as a local variable inside the #ifdef block.
> 
> What's wrong with doing the simpler thing:

I hesitated because of issuing MFSPR twice. But anyway, I have sent the
v2 for your review.

regards
sudip