From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932507AbcBBO4H (ORCPT ); Tue, 2 Feb 2016 09:56:07 -0500 Received: from mail-pf0-f177.google.com ([209.85.192.177]:36792 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752394AbcBBO4E (ORCPT ); Tue, 2 Feb 2016 09:56:04 -0500 Date: Tue, 2 Feb 2016 20:25:54 +0530 From: Sudip Mukherjee To: Johannes Thumshirn Cc: Guenter Roeck , Borislav Petkov , Johannes Thumshirn , Doug Thompson , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH] EDAC, mpc85xx: fix build warning Message-ID: <20160202145554.GB7200@sudip-laptop> References: <1454400021-17583-1-git-send-email-sudipm.mukherjee@gmail.com> <20160202111545.GC3778@pd.tnic> <20160202143801.GA6995@roeck-us.net> <20160202144803.GQ27969@c203.arch.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160202144803.GQ27969@c203.arch.suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2016 at 03:48:03PM +0100, Johannes Thumshirn wrote: > On Tue, Feb 02, 2016 at 06:38:01AM -0800, Guenter Roeck wrote: > > On Tue, Feb 02, 2016 at 12:15:45PM +0100, Borislav Petkov wrote: > > > On Tue, Feb 02, 2016 at 01:30:21PM +0530, Sudip Mukherjee wrote: > > > > We were getting build warning about: > > > > drivers/edac/mpc85xx_edac.c:1247:6: warning: unused variable 'pvr' > > > > > > > > pvr is only used if CONFIG_FSL_SOC_BOOKE was defined. Declare the > > > > variable as a local variable inside the #ifdef block. > > > > > > What's wrong with doing the simpler thing: > > > > > > --- > > > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c > > > index b7139c160baf..f756b6215228 100644 > > > --- a/drivers/edac/mpc85xx_edac.c > > > +++ b/drivers/edac/mpc85xx_edac.c > > > @@ -1244,7 +1244,6 @@ static struct platform_driver * const drivers[] = { > > > static int __init mpc85xx_mc_init(void) > > > { > > > int res = 0; > > > - u32 pvr = 0; > > > > > Or with just adding __maybe_unused here. > > I'd favour this one as well. oops... i just sent the v2 while removing pvr. Which is the better way then? Personally, I donot like __maybe_unused, it is telling gcc that this variable is unused so donot give any warning for it. But in reality it is being used in some cases. regards sudip