From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932990AbcBBPOJ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Feb 2016 10:14:09 -0500
Received: from mail-pf0-f172.google.com ([209.85.192.172]:32840 "EHLO
	mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932526AbcBBPOH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Feb 2016 10:14:07 -0500
Date: Tue, 2 Feb 2016 20:43:57 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
        Guenter Roeck <linux@roeck-us.net>,
        Johannes Thumshirn <morbidrsa@gmail.com>,
        Doug Thompson <dougthompson@xmission.com>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH] EDAC, mpc85xx: fix build warning
Message-ID: <20160202151357.GC7200@sudip-laptop>
References: <1454400021-17583-1-git-send-email-sudipm.mukherjee@gmail.com>
 <20160202111545.GC3778@pd.tnic>
 <20160202143801.GA6995@roeck-us.net>
 <20160202144803.GQ27969@c203.arch.suse.de>
 <20160202145554.GB7200@sudip-laptop>
 <20160202150950.GC15507@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160202150950.GC15507@pd.tnic>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 02, 2016 at 04:09:50PM +0100, Borislav Petkov wrote:
> On Tue, Feb 02, 2016 at 08:25:54PM +0530, Sudip Mukherjee wrote:
> > oops... i just sent the v2 while removing pvr. Which is the better way
> > then?
> > Personally, I donot like __maybe_unused, it is telling gcc that this
> > variable is unused so donot give any warning for it. But in reality it
> > is being used in some cases.
> 
> And? You want to shut up the warning, right?
> 
> Adding __maybe_unused is the simplest variant without disadvantages. Or
> are there any?

another way might be:

diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index b7139c1..968c0c0 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -1244,7 +1244,9 @@ static struct platform_driver * const drivers[] = {
 static int __init mpc85xx_mc_init(void)
 {
 	int res = 0;
+#ifdef CONFIG_FSL_SOC_BOOKE
 	u32 pvr = 0;
+#endif
 
 	printk(KERN_INFO "Freescale(R) MPC85xx EDAC driver, "
 	       "(C) 2006 Montavista Software\n");

regards
sudip