From: Greg KH <gregkh@linuxfoundation.org>
To: "Ksenija Stanojević" <ksenija.stanojevic@gmail.com>
Cc: Willy Tarreau <w@1wt.eu>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: Move panel driver out of staging
Date: Tue, 2 Feb 2016 09:14:53 -0800 [thread overview]
Message-ID: <20160202171453.GD26366@kroah.com> (raw)
In-Reply-To: <CAL7P5jKF28fiW--MDo+bCH4kym3uPgczhtq_G4y34JCwR7N9Cg@mail.gmail.com>
On Tue, Feb 02, 2016 at 05:48:56PM +0100, Ksenija Stanojević wrote:
> Hi Greg,
>
> On Tue, Feb 2, 2016 at 5:23 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Tue, Feb 02, 2016 at 03:38:21PM +0100, Ksenija Stanojevic wrote:
> >> Move panel driver from drivers/staging/panel to drivers/misc.
> >>
> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> >> ---
> >> drivers/misc/Kconfig | 278 ++++
> >> drivers/misc/Makefile | 1 +
> >> drivers/misc/panel.c | 2445 +++++++++++++++++++++++++++++
> >> drivers/staging/Kconfig | 2 -
> >> drivers/staging/Makefile | 1 -
> >> drivers/staging/panel/Kconfig | 278 ----
> >> drivers/staging/panel/Makefile | 1 -
> >> drivers/staging/panel/TODO | 8 -
> >> drivers/staging/panel/lcd-panel-cgram.txt | 24 -
> >> drivers/staging/panel/panel.c | 2445 -----------------------------
> >> 10 files changed, 2724 insertions(+), 2759 deletions(-)
> >> create mode 100644 drivers/misc/panel.c
> >> delete mode 100644 drivers/staging/panel/Kconfig
> >> delete mode 100644 drivers/staging/panel/Makefile
> >> delete mode 100644 drivers/staging/panel/TODO
> >> delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
> >> delete mode 100644 drivers/staging/panel/panel.c
> >
> >
> > Can you generate a patch like this with the -M option to git
> > format-patch?
>
> I tried that but it didn't change anything.
It worked for me:
drivers/misc/Kconfig | 278 ++++++++++++++++++++++++++++++
drivers/misc/Makefile | 1 +
drivers/{staging/panel => misc}/panel.c | 0
drivers/staging/Kconfig | 2 -
drivers/staging/Makefile | 1 -
drivers/staging/panel/Kconfig | 278 ------------------------------
drivers/staging/panel/Makefile | 1 -
drivers/staging/panel/TODO | 8 -
drivers/staging/panel/lcd-panel-cgram.txt | 24 ---
9 files changed, 279 insertions(+), 314 deletions(-)
rename drivers/{staging/panel => misc}/panel.c (100%)
delete mode 100644 drivers/staging/panel/Kconfig
delete mode 100644 drivers/staging/panel/Makefile
delete mode 100644 drivers/staging/panel/TODO
delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
See the lines that show the file being renamed?
How exactly did you export the patch?
> Also, should panel driver have a separate directory in drivers/misc?
For a single driver, I wouldn't worry about that, putting it in misc/ is fine.
But, you dropped the lcd-panel-cgram.txt file, perhaps you want to keep that
somewhere in Documentation/ ?
thanks,
greg k-h
next prev parent reply other threads:[~2016-02-02 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 14:38 Ksenija Stanojevic
2016-02-02 16:23 ` Greg KH
2016-02-02 16:48 ` Ksenija Stanojević
2016-02-02 17:14 ` Greg KH [this message]
2016-02-02 17:19 ` Ksenija Stanojević
2016-02-02 17:44 ` Greg KH
2016-02-02 18:13 ` Ksenija Stanojević
2016-02-02 16:59 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202171453.GD26366@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=ksenija.stanojevic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®