From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934133AbcBBUnk (ORCPT ); Tue, 2 Feb 2016 15:43:40 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:51481 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932865AbcBBUnj (ORCPT ); Tue, 2 Feb 2016 15:43:39 -0500 Date: Tue, 2 Feb 2016 12:43:37 -0800 From: Stephen Boyd To: Masahiro Yamada Cc: linux-clk@vger.kernel.org, Michael Turquette , Linux Kernel Mailing List Subject: Re: [RESEND PATCH v2 10/16] clk: move checking .git_parent to __clk_core_init() Message-ID: <20160202204337.GO4848@codeaurora.org> References: <1451298191-30815-1-git-send-email-yamada.masahiro@socionext.com> <1451298191-30815-11-git-send-email-yamada.masahiro@socionext.com> <20160202005051.GO4848@codeaurora.org> <20160202023922.GL4848@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02, Masahiro Yamada wrote: > 2016-02-02 11:39 GMT+09:00 Stephen Boyd : > > > > Right, this patch moves the check to __clk_core_init(), and it > > will print an error and then keep going (because we lost the goto > > out part). Once we keep going in __clk_core_init() we'll call > > __clk_init_parent() and NULL pointer deref. > > > > Ah, I missed that. > > We need > > ret = -EINVAL; > goto out; > > here, I think. > > Shall I send the v3 for 08/16? > > Or, if it is too late, shall I send a fix-up patch? > I'll split the patch out again and squash in those two lines. Nothing more to do. Thanks. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project