From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932130AbcBCAfv (ORCPT ); Tue, 2 Feb 2016 19:35:51 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:36433 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754186AbcBCAft (ORCPT ); Tue, 2 Feb 2016 19:35:49 -0500 Date: Tue, 2 Feb 2016 16:35:47 -0800 From: Kenneth Westfield To: Srinivas Kandagatla Cc: Patrick Lai , alsa-devel@alsa-project.org, Banajit Goswami , Liam Girdwood , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai , Mark Brown Subject: Re: [alsa-devel] [PATCH RFC 03/15] ASoC: qcom: rename rdmactl_audif_start to dmactrl_audif_start Message-ID: <20160203003547.GD14436@kwestfie-linux.qualcomm.com> Mail-Followup-To: Srinivas Kandagatla , Patrick Lai , alsa-devel@alsa-project.org, Banajit Goswami , Liam Girdwood , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai , Mark Brown References: <1454347622-9970-1-git-send-email-srinivas.kandagatla@linaro.org> <1454347708-10446-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454347708-10446-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2016 at 09:28:28AM -0800, Srinivas Kandagatla wrote: > diff --git a/sound/soc/qcom/lpass-platform.c > b/sound/soc/qcom/lpass-platform.c > index a6dce1b..bfc9de6 100644 > --- a/sound/soc/qcom/lpass-platform.c > +++ b/sound/soc/qcom/lpass-platform.c > @@ -91,7 +91,7 @@ static int lpass_platform_pcmops_hw_params(struct > snd_pcm_substream *substream, > unsigned int channels = params_channels(params); > unsigned int regval; > int bitwidth; > - int ret, rdma_port = pcm_data->i2s_port + v->rdmactl_audif_start; > + int ret, rdma_port = pcm_data->i2s_port + v->dmactl_audif_start; I was wondering why rdma_port had not been changed as well, until I saw that in a later patch. Would it make sense to combine all changes related to removing read-only indications from identifiers to one patch? -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project