From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753984AbcBCLCw (ORCPT ); Wed, 3 Feb 2016 06:02:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46595 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751757AbcBCLCu (ORCPT ); Wed, 3 Feb 2016 06:02:50 -0500 Date: Wed, 3 Feb 2016 12:02:40 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Namhyung Kim , Jiri Olsa , lkml , David Ahern , Ingo Molnar , Peter Zijlstra Subject: Re: [RFC 00/26] perf tools: Introduce hists specific format entries Message-ID: <20160203110240.GA8950@krava.brq.redhat.com> References: <1453109064-1026-1-git-send-email-jolsa@kernel.org> <20160125071552.GB23869@krava.brq.redhat.com> <20160125142424.GA7794@danjae.kornet> <20160125143743.GA10064@krava.brq.redhat.com> <20160202222247.GJ32488@kernel.org> <20160202224216.GL32488@kernel.org> <20160203075853.GB16045@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160203075853.GB16045@krava.brq.redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 03, 2016 at 08:58:53AM +0100, Jiri Olsa wrote: > On Tue, Feb 02, 2016 at 07:42:16PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Feb 02, 2016 at 07:22:47PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Ok, so I rebased it on top of my perf/core branch, adjusting some stuff > > > wrt recent patchkits from Namhyung (hist_entry__callchain_fprintf() is > > > no more, etc), and renaming that perf_hpp_list->{list,sort_list} to > > > ->{fields,sorts} as Namhyung suggested and you agreed, it builds... > > > > > > But perf top isn't showing the overhead column... there were some > > > changes to perf report in this patchkit to move some initializations... > > > will check there... > > > > Fixed, doing the same change you made for 'perf report', moving the > > setup_sorting call to after the setup_browser one, inserted a new patch > > with that just before the patch where the problem was bisected, please > > check. > > > > To recap: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tmp.perf/hists/hpp_list > > > > https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=tmp.perf/hists/hpp_list&id=7d105448f8922679956728a7f5106218378c450e > > I'll check on that, thanks a lot it looks ok to me thanks, jirka