From: Mark Brown <broonie@kernel.org>
To: Harald Geyer <harald@ccbib.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: gpio: Avoid unnecessarily copying data structures in probe()
Date: Wed, 3 Feb 2016 17:20:29 +0000 [thread overview]
Message-ID: <20160203172029.GI4455@sirena.org.uk> (raw)
In-Reply-To: <E1aPBrU-0000QT-G3@stardust.g4.wien.funkfeuer.at>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Fri, Jan 29, 2016 at 05:25:28PM +0100, Harald Geyer wrote:
> Mark Brown writes:
> > On Thu, Jan 28, 2016 at 07:55:17PM +0000, Harald Geyer wrote:
> > > The data structures either have been copied in
> > > of_get_gpio_regulator_config() already or are part of platform data,
> > > which we keep a pointer to for the life time of the device anyway.
> > The point of this code is to avoid referring to platform data after
> > probe for robustness.
> Well, if we can't rely on platform data staying available after probe()
> then probably we shouldn't keep a pointer to it - but thats a different
> issue, so lets focus on the original problem:
> What's your preferred way to fix the error path of probe() then?
Add the matching frees? I'm not sure I know what the original problem
is mind you.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-03 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 19:55 [PATCH 0/2] regulator: gpio: fix error paths " Harald Geyer
2016-01-28 19:55 ` [PATCH 1/2] regulator: gpio: Avoid unnecessarily copying data structures " Harald Geyer
2016-01-28 23:09 ` Mark Brown
2016-01-29 16:25 ` Harald Geyer
2016-02-03 17:20 ` Mark Brown [this message]
2016-01-28 19:55 ` [PATCH 2/2] regulator: gpio: Move last remaining memory allocation to devres Harald Geyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203172029.GI4455@sirena.org.uk \
--to=broonie@kernel.org \
--cc=harald@ccbib.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®