From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933707AbcBCRsR (ORCPT ); Wed, 3 Feb 2016 12:48:17 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:33569 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933336AbcBCRsP (ORCPT ); Wed, 3 Feb 2016 12:48:15 -0500 Date: Wed, 3 Feb 2016 17:47:53 +0000 From: Mark Brown To: "Yang, Wenyou" Cc: Javier Martinez Canillas , Liam Girdwood , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Krzysztof Kozlowski , Lee Jones , Peter Korsgaard , "Ferre, Nicolas" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Message-ID: <20160203174753.GJ4455@sirena.org.uk> References: <1453863463-30515-1-git-send-email-wenyou.yang@atmel.com> <1453863463-30515-2-git-send-email-wenyou.yang@atmel.com> <20160129001603.GM4130@sirena.org.uk> <20160129113518.GQ4130@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KCBbHYs95wY/7dOt" Content-Disposition: inline In-Reply-To: X-Cookie: Duckies are fun! User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for ACT8945A X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --KCBbHYs95wY/7dOt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 03, 2016 at 02:33:11AM +0000, Yang, Wenyou wrote: > > I would just remove the "active-semi,act8945a-regulator" node and make "active- > > semi,vsel-high" a property of the "active-semi,act8945a" node. > > That way you can remove the mfd cell .of_compatible and OF table in the > > regulator driver and read the "active-semi,vsel-high" using the platform device's > > parent of_node. > > But it's better if you wait for Mark's opinions before re-spining your patches. > Hi Mark, what is your opinions? Like Javier says you should make your DT binding look like the DT bindings for other MFDs and not use of_compatible. --KCBbHYs95wY/7dOt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWsj1IAAoJECTWi3JdVIfQMdQH/j0NYzOJ2v9+G9LjVcvUoJXq d0QDzmlrwO/J9DCqEsx6Opb4/d5os+vpU0QefBIpyYjCEw/MPxtmvatQ6H/Aruh5 uC6ZW6lt+N4VuHs0dDzWsUzj0yDTM4kDyYvdpMKuZULOghvRzgfskDTd2O9XE0tm BhDBHQ7DgYG04GWvrWYgNOEn7osIYbi2trIn6OvK21J/vtg7Wfke3hY48LSBStAX yQd0AS878BVfsnvecCLDMPwddaezVigKYok8zM5f2OkStI5NfyeSxY8Ty2oM5S6b xavNbzxx/595JXBraKwW0NxJ6IfTEh0wZZRjrr51U37uDcYgfsx6UsBLCJHICF4= =5o0o -----END PGP SIGNATURE----- --KCBbHYs95wY/7dOt--