From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: david.vrabel@citrix.com, konrad.wilk@oracle.com,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
roger.pau@citrix.com
Subject: Re: [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests delay initializing grant table
Date: Wed, 3 Feb 2016 19:59:48 +0100 [thread overview]
Message-ID: <20160203185948.GW20964@wotan.suse.de> (raw)
In-Reply-To: <1454341137-14110-5-git-send-email-boris.ostrovsky@oracle.com>
On Mon, Feb 01, 2016 at 10:38:50AM -0500, Boris Ostrovsky wrote:
> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
> index c49f79e..9a239d5 100644
> --- a/drivers/xen/grant-table.c
> +++ b/drivers/xen/grant-table.c
> @@ -1147,13 +1147,13 @@ EXPORT_SYMBOL_GPL(gnttab_init);
>
> static int __gnttab_init(void)
> {
> + if (!xen_domain())
> + return -ENODEV;
> +
> /* Delay grant-table initialization in the PV on HVM case */
> - if (xen_hvm_domain())
> + if (xen_hvm_domain() && !xen_hvmlite)
> return 0;
>
> - if (!xen_pv_domain())
> - return -ENODEV;
> -
> return gnttab_init();
> }
For instance if we had pv types generalized then this would just be a one line
addition for __gnttab_init() to support hvmlite. Much cleaner, generalizes the
extensions and gets folks thinking about the types on all calls Xen init call
sites.
Luis
next prev parent reply other threads:[~2016-02-03 18:59 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 15:38 [PATCH v2 00/11] HVMlite domU support Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 01/11] xen/hvmlite: Import hvmlite-related Xen public interfaces Boris Ostrovsky
2016-02-02 16:06 ` [Xen-devel] " David Vrabel
2016-02-01 15:38 ` [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest Boris Ostrovsky
2016-02-02 16:39 ` [Xen-devel] " David Vrabel
2016-02-02 17:19 ` Boris Ostrovsky
2016-02-03 18:55 ` Luis R. Rodriguez
2016-02-03 20:11 ` Boris Ostrovsky
2016-02-03 23:40 ` Luis R. Rodriguez
2016-02-04 19:54 ` Boris Ostrovsky
2016-02-04 20:57 ` Luis R. Rodriguez
2016-02-04 22:28 ` Boris Ostrovsky
2016-02-03 20:52 ` [Xen-devel] " Andrew Cooper
2016-02-03 23:59 ` Luis R. Rodriguez
2016-02-04 0:08 ` Luis R. Rodriguez
2016-02-04 0:51 ` Andrew Cooper
2016-02-04 23:10 ` Luis R. Rodriguez
2016-04-05 22:02 ` Luis R. Rodriguez
2016-04-24 20:23 ` Borislav Petkov
2016-04-25 13:21 ` Boris Ostrovsky
2016-04-25 13:47 ` Borislav Petkov
2016-04-25 13:54 ` Boris Ostrovsky
2016-04-25 14:11 ` Borislav Petkov
2016-04-25 14:42 ` Boris Ostrovsky
2016-04-25 15:22 ` Borislav Petkov
2016-04-25 15:48 ` Boris Ostrovsky
2016-04-26 10:53 ` Borislav Petkov
2016-04-25 17:24 ` [Xen-devel] " David Vrabel
2016-02-01 15:38 ` [PATCH v2 03/11] xen/hvmlite: Initialize HVMlite kernel Boris Ostrovsky
2016-02-17 20:08 ` [Xen-devel] " Luis R. Rodriguez
2016-02-01 15:38 ` [PATCH v2 04/11] xen/hvmlite: Allow HVMlite guests delay initializing grant table Boris Ostrovsky
2016-02-02 16:13 ` [Xen-devel] " David Vrabel
2016-02-02 16:49 ` Boris Ostrovsky
2016-02-03 18:59 ` Luis R. Rodriguez [this message]
2016-02-01 15:38 ` [PATCH v2 05/11] xen/hvmlite: HVMlite guests always have PV devices Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 06/11] xen/hvmlite: Prepare cpu_initialize_context() routine for HVMlite SMP Boris Ostrovsky
2016-02-02 16:16 ` [Xen-devel] " David Vrabel
2016-02-01 15:38 ` [PATCH v2 07/11] xen/hvmlite: Initialize context for secondary VCPUs Boris Ostrovsky
2016-02-02 16:21 ` [Xen-devel] " David Vrabel
2016-02-02 16:58 ` Boris Ostrovsky
2016-02-04 10:07 ` David Vrabel
2016-02-04 12:58 ` Doug Goldstein
2016-02-04 19:08 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 08/11] xen/hvmlite: Extend APIC operations for HVMlite guests Boris Ostrovsky
2016-02-04 10:04 ` [Xen-devel] " David Vrabel
2016-02-04 12:14 ` Roger Pau Monné
2016-02-04 14:01 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 09/11] xen/hvmlite: Use x86's default timer init " Boris Ostrovsky
2016-02-02 16:27 ` [Xen-devel] " David Vrabel
2016-02-02 17:01 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 10/11] xen/hvmlite: Boot secondary CPUs Boris Ostrovsky
2016-02-04 10:38 ` [Xen-devel] " David Vrabel
2016-02-04 13:51 ` Boris Ostrovsky
2016-02-01 15:38 ` [PATCH v2 11/11] xen/hvmlite: Enable CPU on-/offlining Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203185948.GW20964@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®