From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758039AbcBDOdh (ORCPT ); Thu, 4 Feb 2016 09:33:37 -0500 Received: from mx2.suse.de ([195.135.220.15]:49528 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbcBDOdf (ORCPT ); Thu, 4 Feb 2016 09:33:35 -0500 Date: Thu, 4 Feb 2016 15:33:44 +0100 From: Jan Kara To: Dmitry Monakhov Cc: Ross Zwisler , "linux-kernel@vger.kernel.org" , "H. Peter Anvin" , "J. Bruce Fields" , "Theodore Ts'o" , Alexander Viro , Andreas Dilger , Dave Chinner , Ingo Molnar , Jan Kara , Jeff Layton , Matthew Wilcox , Thomas Gleixner , linux-ext4 , linux-fsdevel , Linux MM , "linux-nvdimm@lists.01.org" , X86 ML , XFS Developers , Andrew Morton , Matthew Wilcox , Dave Hansen Subject: Re: [PATCH] dax: dirty inode only if required Message-ID: <20160204143344.GA6895@quack.suse.cz> References: <87k2mkr2ud.fsf@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k2mkr2ud.fsf@openvz.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 04-02-16 17:02:02, Dmitry Monakhov wrote: > > Signed-off-by: Dmitry Monakhov Makes sense. You can add: Reviewed-by: Jan Kara Honza > --- > fs/dax.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/dax.c b/fs/dax.c > index e0e9358..fc2e314 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -358,7 +358,8 @@ static int dax_radix_entry(struct address_space *mapping, pgoff_t index, > void *entry; > > WARN_ON_ONCE(pmd_entry && !dirty); > - __mark_inode_dirty(mapping->host, I_DIRTY_PAGES); > + if (dirty) > + __mark_inode_dirty(mapping->host, I_DIRTY_PAGES); > > spin_lock_irq(&mapping->tree_lock); > > -- > 1.8.3.1 > -- Jan Kara SUSE Labs, CR