From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934200AbcBDTx4 (ORCPT ); Thu, 4 Feb 2016 14:53:56 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:49578 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932594AbcBDTxy (ORCPT ); Thu, 4 Feb 2016 14:53:54 -0500 Date: Thu, 4 Feb 2016 22:53:41 +0300 From: Dan Carpenter To: walter harms Cc: MyungJoo Ham , Jaewon Kim , Chanwoo Choi , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] extcon: use correct size Message-ID: <20160204195341.GB32153@mwanda> References: <20160204113609.GA11239@mwanda> <56B3486D.1050201@bfs.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56B3486D.1050201@bfs.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 04, 2016 at 01:47:41PM +0100, walter harms wrote: > > > Am 04.02.2016 12:36, schrieb Dan Carpenter: > > The info->status[] array has 3 elements. We are using size > > MAX77843_MUIC_IRQ_NUM (16) instead of MAX77843_MUIC_STATUS_NUM (3) as > > intended. > > > > Fixes: 135d9f7d135a ('extcon: max77843: Clear IRQ bits state before request IRQ') > > Signed-off-by: Dan Carpenter > > --- > > This is from static analysis and *NOT TESTED*. Please review carefully. > > > > diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c > > index 7bbc300..b188bd6 100644 > > --- a/drivers/extcon/extcon-max77843.c > > +++ b/drivers/extcon/extcon-max77843.c > > @@ -806,7 +806,7 @@ static int max77843_muic_probe(struct platform_device *pdev) > > /* Clear IRQ bits before request IRQs */ > > ret = regmap_bulk_read(max77843->regmap_muic, > > MAX77843_MUIC_REG_INT1, info->status, > > - MAX77843_MUIC_IRQ_NUM); > > + MAX77843_MUIC_STATUS_NUM); > > if (ret) { > > dev_err(&pdev->dev, "Failed to Clear IRQ bits\n"); > > goto err_muic_irq; > > -- > > > just for my curiosity: what is wrong with ARRAY_SIZE() ? > So far i understand is the functions intention to fill the array > completely. It's done pretty consistently the one way... Jaewon? regards, dan carpenter