From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933932AbcBDU4S (ORCPT ); Thu, 4 Feb 2016 15:56:18 -0500 Received: from box2.japko.eu ([91.121.152.53]:54347 "EHLO box2.japko.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932182AbcBDU4P (ORCPT ); Thu, 4 Feb 2016 15:56:15 -0500 Date: Thu, 4 Feb 2016 21:56:02 +0100 From: Krzysztof Adamski To: Jean-Francois Moine Cc: inus Walleij , Maxime Ripard , Chen-Yu Tsai , Hans de Goede , Lee Jones , Rob Herring , Jens Kuske , Fabian Frederick , Vishnu Patekar , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 1/5] clk: sunxi: Add apb0 gates for H3 Message-ID: <20160204205602.GC12071@box2.japko.eu> References: <1454542430-16572-1-git-send-email-k@japko.eu> <1454542430-16572-2-git-send-email-k@japko.eu> <20160204154752.4df7808be3364a98c496c030@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20160204154752.4df7808be3364a98c496c030@free.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 04, 2016 at 03:47:52PM +0100, Jean-Francois Moine wrote: >On Thu, 4 Feb 2016 00:33:46 +0100 >Krzysztof Adamski wrote: > >> This patch adds support for APB0 in H3. It seems to be compatible with >> earlier SOCs. apb0 gates controls R_ block peripherals (R_PIO, R_IR, >> etc). >> >> Signed-off-by: Krzysztof Adamski >> --- >> Documentation/devicetree/bindings/clock/sunxi.txt | 1 + >> drivers/clk/sunxi/clk-simple-gates.c | 2 ++ >> 2 files changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/sunxi.txt b/Documentation/devicetree/bindings/clock/sunxi.txt >> index e59f57b..751c8b9f0 100644 >> --- a/Documentation/devicetree/bindings/clock/sunxi.txt >> +++ b/Documentation/devicetree/bindings/clock/sunxi.txt >> @@ -45,6 +45,7 @@ Required properties: >> "allwinner,sun6i-a31-apb0-gates-clk" - for the APB0 gates on A31 >> "allwinner,sun7i-a20-apb0-gates-clk" - for the APB0 gates on A20 >> "allwinner,sun8i-a23-apb0-gates-clk" - for the APB0 gates on A23 >> + "allwinner,sun8i-h3-apb0-gates-clk" - for the APB0 gates on H3 >> "allwinner,sun9i-a80-apb0-gates-clk" - for the APB0 gates on A80 >> "allwinner,sun4i-a10-apb1-clk" - for the APB1 clock >> "allwinner,sun9i-a80-apb1-clk" - for the APB1 bus clock on A80 >> diff --git a/drivers/clk/sunxi/clk-simple-gates.c b/drivers/clk/sunxi/clk-simple-gates.c >> index f4da52b..6753c87 100644 >> --- a/drivers/clk/sunxi/clk-simple-gates.c >> +++ b/drivers/clk/sunxi/clk-simple-gates.c >> @@ -130,6 +130,8 @@ CLK_OF_DECLARE(sun8i_a23_apb2, "allwinner,sun8i-a23-apb2-gates-clk", >> sunxi_simple_gates_init); >> CLK_OF_DECLARE(sun8i_a33_ahb1, "allwinner,sun8i-a33-ahb1-gates-clk", >> sunxi_simple_gates_init); >> +CLK_OF_DECLARE(sun8i_h3_apb0, "allwinner,sun8i-h3-apb0-gates-clk", >> + sunxi_simple_gates_init); >> CLK_OF_DECLARE(sun9i_a80_ahb0, "allwinner,sun9i-a80-ahb0-gates-clk", >> sunxi_simple_gates_init); >> CLK_OF_DECLARE(sun9i_a80_ahb1, "allwinner,sun9i-a80-ahb1-gates-clk", > >It seems that the other compatible strings are there for historical >reasons. Why do you need a new one with such a specific name? > >It would have been more sensible to add a generic compatible string as >"allwinner,apb-gates", letting the removal of the other strings for a >later patch... Seems like a good idea but is it possible to remove those binding in separate patch? I mean, wouldn't that, in theory, break ABI? Are such patches accepted?