From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756584AbcBDWjc (ORCPT ); Thu, 4 Feb 2016 17:39:32 -0500 Received: from mail-sn1nam02on0063.outbound.protection.outlook.com ([104.47.36.63]:45120 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753143AbcBDWja (ORCPT ); Thu, 4 Feb 2016 17:39:30 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Thu, 4 Feb 2016 14:41:29 -0800 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Grygorii Strashko CC: Daniel Lezcano , Arnd Bergmann , Olof Johansson , , , , , , , , , Florian Fainelli , Russell King , Wei Xu , Shawn Guo , Sascha Hauer , Srinivas Kandagatla , Maxime Coquelin , Masahiro Yamada , Liviu Dudau , "Sudeep Holla" , Jun Nie , Michal Simek Subject: Re: [RFC PATCH] ARM: clocksource: make ARM_GLOBAL_TIMER selectable Message-ID: <20160204224128.GG4215@xsjsorenbubuntu> References: <1454610017-25499-1-git-send-email-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1454610017-25499-1-git-send-email-grygorii.strashko@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22110.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(199003)(189002)(377424004)(33716001)(1096002)(54356999)(106466001)(586003)(85202003)(107886002)(5001960100002)(110136002)(2950100001)(4001430100002)(11100500001)(47776003)(50986999)(2870700001)(6806005)(19580405001)(189998001)(1220700001)(5008740100001)(2906002)(83506001)(19580395003)(4001350100001)(76176999)(57986006)(36386004)(77096005)(4326007)(86362001)(33656002)(1076002)(87936001)(63266004)(76506005)(92566002)(50466002)(575784001)(23676002)(85182001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1NAM02HT045;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 54c3255d-c3fc-4a0a-7180-08d32db40a95 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CY1NAM02HT045; X-Microsoft-Antispam-PRVS: <45ea8a7634294ff38bd366d4cd9dfec0@CY1NAM02HT045.eop-nam02.prod.protection.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(192813158149592)(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(13023025)(5005006)(8121501046)(13024025)(13015025)(13017025)(10201501046)(3002001);SRVR:CY1NAM02HT045;BCL:0;PCL:0;RULEID:;SRVR:CY1NAM02HT045; X-Forefront-PRVS: 084285FC5C X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2016 22:39:27.1800 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1NAM02HT045 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-02-04 at 20:20:17 +0200, Grygorii Strashko wrote: > This patch intended to fix following cases: > - SoC-A has ARM GT, defines DT node for ARM GT and selects ARM_GLOBAL_TIMER > statically in Kconfig file. SoC-B has ARM GT and defines DT node for ARM GT, > but do not selects ARM_GLOBAL_TIMER statically in Kconfig file. In case of > multiplatform build ARM GT will be implicitly enabled for SoC-B. > > - There is no way to disable ARM GT without modifying Kconfig file, > once ARM_GLOBAL_TIMER is selected statically in Kconfig file. > > Hence, fix above case by defining both HAVE_ARM_GLOBAL_TIMER and > ARM_GLOBAL_TIMER as recommended by 'Adding common features and make > the usage configurable' section in kconfig-language.txt. All places in > ARM folder where ARM_GLOBAL_TIMER was used now replaced on > HAVE_ARM_GLOBAL_TIMER. > > Cc: Florian Fainelli > Cc: Russell King > Cc: Wei Xu > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Srinivas Kandagatla > Cc: Maxime Coquelin > Cc: Masahiro Yamada > Cc: Liviu Dudau > Cc: Sudeep Holla > Cc: Jun Nie > Cc: Michal Simek > Cc: "Sören Brinkmann" > Cc: Daniel Lezcano > > Signed-off-by: Grygorii Strashko > --- [...] > diff --git a/arch/arm/mach-zynq/Kconfig b/arch/arm/mach-zynq/Kconfig > index fd0aeeb..3165720 100644 > --- a/arch/arm/mach-zynq/Kconfig > +++ b/arch/arm/mach-zynq/Kconfig > @@ -5,7 +5,7 @@ config ARCH_ZYNQ > select ARCH_SUPPORTS_BIG_ENDIAN > select ARM_AMBA > select ARM_GIC > - select ARM_GLOBAL_TIMER if !CPU_FREQ > + select HAVE_ARM_GLOBAL_TIMER if !CPU_FREQ We actually have this issue, as we don't want to use GT when CPU_FREQ is enabled. But with this change the 'if !CPU_FREQ' becomes obsolete. Acked-by: Sören Brinkmann Sören