From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932213AbcBEQbK (ORCPT ); Fri, 5 Feb 2016 11:31:10 -0500 Received: from smtprelay0218.hostedemail.com ([216.40.44.218]:48756 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751510AbcBEQah (ORCPT ); Fri, 5 Feb 2016 11:30:37 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2892:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:4321:5007:6261:7774:7875:7903:7904:10004:10400:10848:10967:11026:11232:11473:11658:11914:12296:12438:12517:12519:12555:12663:12740:13069:13311:13357:13972:14096:14097:14659:21080:30036:30045:30054:30075:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: cloud90_7950701ca1a5d X-Filterd-Recvd-Size: 2578 Date: Fri, 5 Feb 2016 11:30:32 -0500 From: Steven Rostedt To: Petr Mladek Cc: Torsten Duwe , Michael Ellerman , Jiri Kosina , Miroslav Benes , Jessica Yu , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Message-ID: <20160205113032.620c97f3@gandalf.local.home> In-Reply-To: <20160205161834.GF731@pathway.suse.cz> References: <20160204161527.5F3AC692CD@newverein.lst.de> <20160204162053.C76A7692D8@newverein.lst.de> <20160205140517.GE3305@pathway.suse.cz> <20160205094803.1e0c6c91@gandalf.local.home> <20160205161834.GF731@pathway.suse.cz> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Feb 2016 17:18:34 +0100 Petr Mladek wrote: > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > index a138f6d..de6dab0 100644 > --- a/kernel/trace/Kconfig > +++ b/kernel/trace/Kconfig > @@ -449,7 +449,7 @@ config PROBE_EVENTS > def_bool n > > config DYNAMIC_FTRACE > - bool "enable/disable function tracing dynamically" > + bool "Enable/Disable function tracing dynamically" > depends on FUNCTION_TRACER > depends on HAVE_DYNAMIC_FTRACE > default y > @@ -472,9 +472,17 @@ config DYNAMIC_FTRACE > otherwise has native performance as long as no tracing is active. > > config DYNAMIC_FTRACE_WITH_REGS > - def_bool y > + bool "Pass registers to function tracer" > depends on DYNAMIC_FTRACE > depends on HAVE_DYNAMIC_FTRACE_WITH_REGS > + default y > + help > + This option enables passing the current state of processor > + registers to the function tracer. It allows to do a more > + detailed analyze and print more information. > + > + Say Y here if you are unsure. The only exception is if > + you want to pass a build error caused by a broken compiler. > > config FUNCTION_PROFILER > bool "Kernel function profiler" > > > I made "enable/disable" uppercase because it looked weird in > context of other descritions. > This works too, and I'm fine with it. -- Steve