From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753685AbcBENng (ORCPT ); Fri, 5 Feb 2016 08:43:36 -0500 Received: from box2.japko.eu ([91.121.152.53]:55455 "EHLO box2.japko.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753587AbcBENnd (ORCPT ); Fri, 5 Feb 2016 08:43:33 -0500 Date: Fri, 5 Feb 2016 14:43:18 +0100 From: Krzysztof Adamski To: Linus Walleij Cc: Maxime Ripard , Chen-Yu Tsai , Hans de Goede , Lee Jones , Rob Herring , Jens Kuske , Fabian Frederick , Vishnu Patekar , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-sunxi Subject: Re: [PATCH v2] pinctrl: sunxi: H3 requires irq_read_needs_mux Message-ID: <20160205134317.GE12071@box2.japko.eu> References: <20160203075713.GA23312@box2.japko.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2016 at 02:39:23PM +0100, Linus Walleij wrote: >On Wed, Feb 3, 2016 at 8:57 AM, Krzysztof Adamski wrote: > >> It seems that on H3, just like on A10, when GPIOs are configured as >> external interrupt data registers does not contain their value. When >> value is read, GPIO function must be temporary switched to input for >> reads. >> >> Signed-off-by: Krzysztof Adamski > >2. Is this a regression that need to go in to fixes? Not sure what you mean by that. H3 support was added recently without this flag so it never worked properly on this SoC. With this patch it does. So it's just a normal bug fix, not a regression. Best regards, Krzysztof Adamski