From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754401AbcBEOFX (ORCPT ); Fri, 5 Feb 2016 09:05:23 -0500 Received: from mx2.suse.de ([195.135.220.15]:47247 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754348AbcBEOFV (ORCPT ); Fri, 5 Feb 2016 09:05:21 -0500 Date: Fri, 5 Feb 2016 15:05:17 +0100 From: Petr Mladek To: Torsten Duwe Cc: Michael Ellerman , Jiri Kosina , Miroslav Benes , Jessica Yu , Steven Rostedt , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Message-ID: <20160205140517.GE3305@pathway.suse.cz> References: <20160204161527.5F3AC692CD@newverein.lst.de> <20160204162053.C76A7692D8@newverein.lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160204162053.C76A7692D8@newverein.lst.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2016-01-25 16:29:54, Torsten Duwe wrote: > diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c > index ef8b916..29b7014 100644 > --- a/arch/powerpc/kernel/ftrace.c > +++ b/arch/powerpc/kernel/ftrace.c > @@ -28,6 +28,11 @@ > > > #ifdef CONFIG_DYNAMIC_FTRACE > +#if defined(CONFIG_DYNAMIC_FTRACE_WITH_REGS) && defined(CONFIG_PPC64) && \ > + !defined(CC_USING_MPROFILE_KERNEL) > +#error "DYNAMIC_FTRACE_WITH_REGS requires working -mprofile-kernel" > +#endif CONFIG_DYNAMIC_FTRACE_WITH_REGS is automatically enabled when both CONFIG_DYNAMIC_FTRACE and HAVE_DYNAMIC_FTRACE_WITH_REGS are enabled. Therefore it is not possible to build kernel with broken gcc and DYNAMIC_FTRACE. IMHO, we need to allow to explicitely disable DYNAMIC_FTRACE_WITH_REGS if the compiler is broken to get around this build error. We either need to define DYNAMIC_FTRACE_WITH_REGS as a proper bool with description, help text, ... Or we need a way to explicitely disable HAVE_DYNAMIC_FTRACE_WITH_REGS. Or something like this. Best Regards, Petr