From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756166AbcBERov (ORCPT ); Fri, 5 Feb 2016 12:44:51 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:35129 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752878AbcBERot (ORCPT ); Fri, 5 Feb 2016 12:44:49 -0500 Date: Fri, 5 Feb 2016 09:44:30 -0800 From: Shaohua Li To: Tejun Heo CC: , , Subject: Re: [PATCH] block-dev: enable writeback cgroup support Message-ID: <20160205174413.GA1685536@devbig084.prn1.facebook.com> References: <20160205172139.GF4401@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160205172139.GF4401@htj.duckdns.org> User-Agent: Mutt/1.5.20 (2009-12-10) X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-02-05_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2016 at 12:21:39PM -0500, Tejun Heo wrote: > On Mon, Feb 01, 2016 at 05:50:33PM -0800, Shaohua Li wrote: > > block_dev's .writepages/.writepage already handles > > wbc_init_bio/wbc_account_io. We only set the SB_I_CGROUPWB bit to > > suppport writeback cgroup support. > > > > Signed-off-by: Shaohua Li > > Acked-by: Tejun Heo > > Can you please describe a bit how you tested it tho? I'm doing a simple buffered write to a disk, assign it to a cgroup and blk-throttle sets wbps for the disk/cgroup. then I'm watching iostat with/without the bit set. Thanks, Shaohua