From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pan Xinhui <xinhui@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
mnipxh@163.com, yanmin_zhang@linux.intel.com,
alan@linux.intel.com
Subject: Re: [PATCH V2] tty/n_gsm.c: use gsm->num to remove mux itself from gsm_mux[]
Date: Sat, 6 Feb 2016 23:29:47 -0800 [thread overview]
Message-ID: <20160207072947.GA1214@kroah.com> (raw)
In-Reply-To: <568B73FC.7020407@linux.vnet.ibm.com>
On Tue, Jan 05, 2016 at 03:42:52PM +0800, Pan Xinhui wrote:
> From: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
>
> There is one filed gsm->num to store mux's index of gsm_mux[]. So use
> gsm->num to remove itself from gsm_mux[] instead of the for-loop
> traverse in gsm_cleanup_mux().
>
> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
> Reviewed-by: Alan Cox <alan@linux.intel.com>
> ---
> change from V1:
> lock is also held for the if()
> ---
> drivers/tty/n_gsm.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
Doesn't apply to my tty-next branch of the tty.git tree :(
next prev parent reply other threads:[~2016-02-07 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 7:42 Pan Xinhui
2016-01-05 12:22 ` One Thousand Gnomes
2016-02-07 7:29 ` Greg Kroah-Hartman [this message]
2016-02-07 14:02 ` Pan Xinhui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160207072947.GA1214@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mnipxh@163.com \
--cc=xinhui@linux.vnet.ibm.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome