mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Benjamin Young <youngcdev@gmail.com>
Cc: sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: goldfish: Coding Style Fix - spaces preferred around that '+'
Date: Sun, 7 Feb 2016 18:29:44 -0800	[thread overview]
Message-ID: <20160208022944.GA19703@kroah.com> (raw)
In-Reply-To: <1449869939-14545-1-git-send-email-youngcdev@gmail.com>

On Fri, Dec 11, 2015 at 04:38:59PM -0500, Benjamin Young wrote:
> Helped improve coding style to make arithemethic easier to read
> 
> Signed-off-by: Benjamin Young <youngcdev@gmail.com>
> ---
>  drivers/staging/goldfish/goldfish_audio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
> index b0927e4..f1e1838 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -63,7 +63,7 @@ struct goldfish_audio {
>  #define AUDIO_READ(data, addr)		(readl(data->reg_base + addr))
>  #define AUDIO_WRITE(data, addr, x)	(writel(x, data->reg_base + addr))
>  #define AUDIO_WRITE64(data, addr, addr2, x)	\
> -	(gf_write_dma_addr((x), data->reg_base + addr, data->reg_base+addr2))
> +	(gf_write_dma_addr((x), data->reg_base + addr, data->reg_base + addr2))
>  
>  /*
>   *  temporary variable used between goldfish_audio_probe() and

Someone else sent this before you did, sorry.

thanks,

greg k-h

  reply	other threads:[~2016-02-08  2:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 21:38 Benjamin Young
2016-02-08  2:29 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-12-10 23:29 Benjamin Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160208022944.GA19703@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=youngcdev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®