From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755131AbcBHC34 (ORCPT ); Sun, 7 Feb 2016 21:29:56 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49947 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754860AbcBHC3y (ORCPT ); Sun, 7 Feb 2016 21:29:54 -0500 Date: Sun, 7 Feb 2016 18:29:54 -0800 From: Greg KH To: Benjamin Young Cc: sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: goldfish: Coding Style Fix Comparison to NULL could be written "!r" Message-ID: <20160208022954.GB19703@kroah.com> References: <1449869966-14605-1-git-send-email-youngcdev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449869966-14605-1-git-send-email-youngcdev@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 11, 2015 at 04:39:26PM -0500, Benjamin Young wrote: > Fixed coding style for null comparisons in goldfish_audio.c to be more consistant > with the rest of the kernel coding style > > Signed-off-by: Benjamin Young > --- > drivers/staging/goldfish/goldfish_audio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c > index f1e1838..364fdcd 100644 > --- a/drivers/staging/goldfish/goldfish_audio.c > +++ b/drivers/staging/goldfish/goldfish_audio.c > @@ -280,12 +280,12 @@ static int goldfish_audio_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, data); > > r = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (r == NULL) { > + if (!r) { > dev_err(&pdev->dev, "platform_get_resource failed\n"); > return -ENODEV; > } > data->reg_base = devm_ioremap(&pdev->dev, r->start, PAGE_SIZE); > - if (data->reg_base == NULL) > + if (!data->reg_base) > return -ENOMEM; > > data->irq = platform_get_irq(pdev, 0); > @@ -295,7 +295,7 @@ static int goldfish_audio_probe(struct platform_device *pdev) > } > data->buffer_virt = dmam_alloc_coherent(&pdev->dev, > COMBINED_BUFFER_SIZE, &buf_addr, GFP_KERNEL); > - if (data->buffer_virt == NULL) { > + if (!data->buffer_virt) { > dev_err(&pdev->dev, "allocate buffer failed\n"); > return -ENOMEM; > } Same here, someone beat you to it.