From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755547AbcBHF1h (ORCPT ); Mon, 8 Feb 2016 00:27:37 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37376 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754092AbcBHF1g (ORCPT ); Mon, 8 Feb 2016 00:27:36 -0500 Date: Sun, 7 Feb 2016 21:27:35 -0800 From: Greg Kroah-Hartman To: Shraddha Barke Cc: Peter Senna Tschudin , Dan Carpenter , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Platform: goldfish: goldfish_pipe.c: Add DMA support using managed version Message-ID: <20160208052735.GA21371@kroah.com> References: <1454735180-4977-1-git-send-email-shraddha.6596@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454735180-4977-1-git-send-email-shraddha.6596@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 06, 2016 at 10:36:20AM +0530, Shraddha Barke wrote: > setup_access_params_addr has 2 goals- > > -Initialize the access_params field so that it can be used to send and read > commands from the device in access_with_param > -Get a bus address for the allocated memory to transfer to the device. > > Replace the combination of devm_kzalloc and _pa() with dmam_alloc_coherent. > Coherent mapping guarantees that the device and CPU are in sync. > > Signed-off-by: Shraddha Barke > --- > drivers/platform/goldfish/goldfish_pipe.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Doesn't apply to my char-misc tree anymore due to other changes in the driver, can you rebase and resend? thanks, greg k-h