From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752237AbcBHKNz (ORCPT ); Mon, 8 Feb 2016 05:13:55 -0500 Received: from verein.lst.de ([213.95.11.211]:60642 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653AbcBHKNx (ORCPT ); Mon, 8 Feb 2016 05:13:53 -0500 Date: Mon, 8 Feb 2016 11:13:50 +0100 From: Christoph Hellwig To: Sagi Grimberg Cc: Hannes Reinecke , James Bottomley , Jens Axboe , Christoph Hellwig , linux-block@vger.kernel.org, linux-scsi , "linux-nvme@lists.infradead.org" , linux-kernel Subject: Re: complete boot failure in 4.5-rc1 caused by nvme: make SG_IO support optional Message-ID: <20160208101350.GA32632@lst.de> References: <1454783624.2809.6.camel@HansenPartnership.com> <20160207092241.GA15331@lst.de> <1454861040.2329.4.camel@HansenPartnership.com> <56B7C527.6050300@kernel.dk> <1454886441.2329.27.camel@HansenPartnership.com> <56B8448A.3000106@suse.de> <56B8676C.20600@dev.mellanox.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56B8676C.20600@dev.mellanox.co.il> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08, 2016 at 12:01:16PM +0200, Sagi Grimberg wrote: > >> Do we have defined sysfs attributes for NVMe devices nowadays? > > /sys/block/nvme0n1/uuid That's only supported for NVMe 1.1 and higher devices, and optional. For older or stupid devices we need to support the algorithm based on the serial attribute from nvme_fill_device_id_scsi_string() in drivers/nvme/host/scsi.c. Which btw is Ń–ncorrect as it doesn't identify namespaces properly, and thus the associatation of 0 is an actively harmful lie.