From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752191AbcBHNsz (ORCPT ); Mon, 8 Feb 2016 08:48:55 -0500 Received: from mail-by2on0087.outbound.protection.outlook.com ([207.46.100.87]:32293 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750935AbcBHNsy (ORCPT ); Mon, 8 Feb 2016 08:48:54 -0500 Authentication-Results: cogentembedded.com; dkim=none (message not signed) header.d=none;cogentembedded.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Mon, 8 Feb 2016 14:48:35 +0100 From: Robert Richter To: Sergei Shtylyov CC: , , , , Subject: Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address Message-ID: <20160208134835.GX24726@rric.localdomain> References: <1454933272-45005-1-git-send-email-sunil.kovvuri@gmail.com> <1454933272-45005-6-git-send-email-sunil.kovvuri@gmail.com> <56B8987D.7000901@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <56B8987D.7000901@cogentembedded.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.224.193.76] X-ClientProxiedBy: HE1PR03CA0025.eurprd03.prod.outlook.com (25.163.170.163) To BY1PR0701MB1612.namprd07.prod.outlook.com (25.162.110.153) X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1612;2:lDIRj+DSyIdErlGdBOgb87/tBE1dJdxh15aheFGXffKwwemK0gX+/dIsTg2siH9wmUv8sEquTgT2l33tymtatt1Q3YfwCjnaHd1dGHVAJUy3MKoKxRPHS/yjXlZtZPUMxQK02LcAjbpX6tikLElxTw==;3:bceUbfbBbcuvzVas4Ocm49MwHCWdK/E0tLyCqcUmuL8ghQVLHkRe3Q28Fp08MzJOXOGNQsfQfKCFifqGTFImSfNguAGYksq92bn5szjNbrDdnmnt0mk3UyGvvq2fHa/5;25:QPt7zgfK96WVM5x1nkeXpl+A5Ag8cUGTO3gruEt0vprJttQ2HFJp/eIT1H3EhZiTQUex3HRaWUXg2oTVRxzsDGgIwpMjmRLUNnd60z63oauhvlvwOjHNUXg96lzml2A5d5H6aPzBKTZfOlkA676QtX7dNke5N1jKXkkkcDiiXrrJAUKxdviAX2jeo/IALV8pkAjmq1jNkSWgDWgYWza6hWuXevk3Fn2Ks+3Eedkmhi38q8wBYZrTGI1dWbCM3nS7hzuNvDxlgw8tsmdQNMdU5c+mn0QiiI2tB0PM4YYwn9H9FV6xDIQ2vw6bo8ppxsnZ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1612; X-MS-Office365-Filtering-Correlation-Id: e45de924-4bb7-4ddd-323b-08d3308e9464 X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1612;20:Ay/7vQ8McbwD80Z6qI1wyJ/i2ferUzu1BQIvurF/v5LEHvvnW3Mx5Y4V701ZUTqMYAY0kWTopraDKR1BsuaK6YUE+KjAhFp2Lsz9ytHYGcKF8uD3eSl57LRjU8XsYfCbjV9VQA4Bag8eDM9spglZ+ZoQSEHV76jy25SXtXFE3QN8NtHpRKzWF9qRAdoU/LXgXyS3ss1FkT21kgwjLPVQcMFIzG4/yUi7ceXloMPWQtZTRmXfQywYLwBAUTk4Fv3kXFLRb1oMI7xbd6mH1Cl46ED4Mu6EkAPlIflDgBQRmsEfWzM/DVSxcKlXMsaRUCnLSHM5DWjNzAxQJQn55sOZrDWeN0RJln17M1BeNA+onR55UeCjwEyA3R6hznuVIxiGfryNC+AvmATNBY04sZfsxpIq0hf1Sj7HECDfYz1GZ9ZpAuBlWltK+U8TdkXjo1wqvALMFJzGLM2MYdaXiKV90+P7KdhwpGKSPwpC1lLc5FXuAov7covBgj1jJC09+3mq5O1EPeyRb8CHUW7rJsbWYxen1uklaczlESwGuwsJrZPFpw8LT6ttLPl20eN2aOE+JWXrAXgt6PyUHVobwu92Y1EbPPM0sGO0WstOGlNKtDk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BY1PR0701MB1612;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1612; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1612;4:DYdpYOXJU4s1FilP/cLsvsrCn0xvpV+9KHetKDzdI+IPZ9ryvLNkw+alN9gWTB/IkYFg5BYOmUhIIEqUqpbhEm8UB26e4+FC7rMCe4oDQzZUMEOYjpjacICJ+ASzrtRyO7W2H2tJyiXWXTlHLeADHQh5YIN2Ff0+I1nxtR51U8tK+atnoJaE7BvESr+PSBCr+AKlzgqlAYv7vALhxEQIRJ3hp2ZFTrOuwa94noKF44NIF+CRny5igVwmClbVrHXmWk180jIDvqAMhQNYurBH4YnB7s/czTVVJ4G1VpCPp0gZ5yXcU5JDp5U30iJ/i/MoXsoXxhBfhTVxSYiAZ0B1LLjqBU/GBq98jNXv2hIge9eM7a7ZDEAKQx3pP2HUb+7E X-Forefront-PRVS: 084674B2CF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(42186005)(46406003)(87976001)(33656002)(2906002)(586003)(23726003)(3846002)(6116002)(4326007)(66066001)(1096002)(1076002)(77096005)(2950100001)(47776003)(76176999)(54356999)(50986999)(97756001)(86362001)(83506001)(40100003)(50466002)(5008740100001)(5004730100002)(4001350100001)(189998001)(110136002)(5001960100002)(122386002)(92566002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0701MB1612;H:rric.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1612;23:m7POQoJ5usbhVr99UVCiSa+R6Dr5OPpRYUNXM8GQUR0QHrhQo8n1WMuRITlHQBNeJ3VNKAUqOQ7iY6pfC+dQD3J9pwbwQxFZMVGxbHVncgz26bHidO5hiOv2bYebCWqtHHjU86ZZyEz6Et8Vvm7DXYS1mgV6iaUnS3yAsHMItOlJP/C4kpkA8m46Iu+Pd+R30Vu8jm4zzPmumS6Ea9tpwDTA/RZOpObE71wYCopR9ertQunjzZpMR61uuWzLN5m2x1rjgfsm/VfDpDMpqyUY+GmWOrXsoS+9/T0vVW6yE8iNkBauoQY2fefj6zxRD8pTAdNvJDTQaRfcVfImkE9D3nA6R34nuNLi0NIe3TXVQvFSilgBLRWyYpk+cFf8aZQvvCmceqgmtAGDyhMQne8ShE5+MNQJ4UW2VP3F6zsIoMY0Q8xhj7Onb3XagJxtESs3a8IcU/7fiwDfThEELCTa4RhYlUrSw/QnqEnNPwJDz7Rlx1XICnbuCIUE9HBgKbTYuIu3GhNbUW/bTJz+79JacwplCx5ou4jI3JhcFpZFE5ZLtozJUO3ayjWcSgUKAhpHK2BMLz2bRrwzOEtCPFspzNejmJY+rKV3AJE7USyefDkyiGZ351aGhNX6eio53GMoCTn8/kYZKMtYmb+W4+Nr7teElQD2ricQB/u4Iq1i8ewlw+lZoCOLihSCWJsCy0HzPK2z8fYiRCuwMbS68soaH91bwFabk+H+GEjPXG6hOh4VLYjwDTYrRHJkwRCVP+fCujw+Lj64Vni1GjhgVBkXxi69CHHe/mOhBITBJXn4PoBYXMxcBG2URMZu0i9q6L/h/uQu6Nfp80tT2Rhq+6VKD4GRKoLNdq1AwqXD6dRy8da/wJnUVzNWQQz/q2ZMRbI3RAGTmrjua2gUIc7P3THrkxTAtFmrVNKuf9sUsBsHPpo= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1612;5:Tm5q5ANe/1UFw0Y0R1fK1tksJYRwLpP4Zg7loEmnxGpFMgJhWTcmB51o2lO0cdvGZWCMuJVaXM3ZTkVmFYb+a2WDoLTqjHhZ1cSQuKSuMxLqL/DmkUDPzwU3O9J4hDKn14QipE/aJqefny1dj5jTkg==;24:CRs4f3uIjzpB+fpe56CN7KF+6brGZ8Jf3UGHYCOR8uM06lLmIS41OBOJauvztt+hM7/aqyCubP9v6wFthMiI4jjcvV8/oLQTaLVpqa1GzSU= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2016 13:48:50.0579 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1612 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.02.16 16:30:37, Sergei Shtylyov wrote: > >@@ -897,10 +898,13 @@ static int acpi_get_mac_address(struct acpi_device *adev, u8 *dst) > > goto out; > > > > if (!is_valid_ether_addr(mac)) { > >+ dev_warn(dev, "MAC address invalid: %pM\n", mac); > > dev_er(), maybe? Since the driver may continue, my choice was a warning only. -Robert > > > ret = -EINVAL; > > goto out; > > } > > > >+ dev_info(dev, "MAC address set to: %pM\n", mac); > >+ > > memcpy(dst, mac, ETH_ALEN); > > out: > > return ret; > [...]