From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755801AbcBHQw5 (ORCPT ); Mon, 8 Feb 2016 11:52:57 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:40005 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755104AbcBHQw1 (ORCPT ); Mon, 8 Feb 2016 11:52:27 -0500 Date: Mon, 8 Feb 2016 08:52:26 -0800 From: Greg KH To: Vladimir Murzin Cc: arnd@arndb.de, linux@arm.linux.org.uk, daniel.lezcano@linaro.org, tglx@linutronix.de, u.kleine-koenig@pengutronix.de, andy.shevchenko@gmail.com, mark.rutland@arm.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, jslaby@suse.cz, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-api@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Message-ID: <20160208165226.GA11593@kroah.com> References: <1454413199-26573-1-git-send-email-vladimir.murzin@arm.com> <1454413199-26573-5-git-send-email-vladimir.murzin@arm.com> <20160207071154.GA32017@kroah.com> <56B87928.7020803@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56B87928.7020803@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08, 2016 at 11:16:56AM +0000, Vladimir Murzin wrote: > On 07/02/16 07:11, Greg KH wrote: > >> + > >> +#define SERIAL_NAME "ttyS" > > > > You can't be "ttyS", there's already a serial port named that, please > > use a unique name and a new major/minor number (dynamic ideally). > > > > Hi Greg, > > I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it > back if you prefer that, but I'd be glad to know what I've been missing? > > [1] https://lkml.org/lkml/2015/12/13/8 Yeah, I was wrong, sorry about that, my fault. greg k-h