From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755093AbcBHQ72 (ORCPT ); Mon, 8 Feb 2016 11:59:28 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40256 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbcBHQ71 (ORCPT ); Mon, 8 Feb 2016 11:59:27 -0500 Date: Mon, 8 Feb 2016 16:59:12 +0000 From: Mark Brown To: Laxman Dewangan Cc: lee.jones@linaro.org, alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com, javier@osg.samsung.com, gregkh@linuxfoundation.org, a.zummo@towertech.it, cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Message-ID: <20160208165912.GK7265@sirena.org.uk> References: <1454769447-785-1-git-send-email-ldewangan@nvidia.com> <1454769447-785-2-git-send-email-ldewangan@nvidia.com> <20160208145550.GE7265@sirena.org.uk> <56B8C484.7000309@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pN9MePJoZbRKbUk1" Content-Disposition: inline In-Reply-To: <56B8C484.7000309@nvidia.com> X-Cookie: All work and no pay makes a housewife. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pN9MePJoZbRKbUk1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 08, 2016 at 10:08:28PM +0530, Laxman Dewangan wrote: > On Monday 08 February 2016 08:25 PM, Mark Brown wrote: > >On Sat, Feb 06, 2016 at 08:07:22PM +0530, Laxman Dewangan wrote: > >>Before removing irq domains, it is require to unmap all > >>mapped interrupt from that domain. Currently there is API > >>to map the interrupt on chip as regmap_irq_get_virq() for > >>creating mapping. Add equivalent API to dispose the mapped > >>irq in irq domains. > >This makes no sense to me. Why would you ever want to unmap the > >interrupts separately to destroying the domain > This is the requirement from irq_domain_remove(). This is what we have in > irq_domain_remove(): > kernel/irq/irqdomain.c > I am adding the API equivalent to regmap_irq_get_virq() to unmap virtual = irq > here. This does not explain why anyone would ever want to use this interface (which was my question), why would anyone ever want to do this as a separate step? > >and why would you ever > >want to destroy the domain without unmapping the interrupts? > That's exactlly we are trying to do, unmap interrupt in client level befo= re > destroying domain. Again, why would any client ever want to skip this step?=20 --pN9MePJoZbRKbUk1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWuMlfAAoJECTWi3JdVIfQc3wH/2FjUQzwY5sqMGy73YvPz10D lzxgxDTsgYrlcrC0xxEBTpxhpdhk7qN++fCs7ttLDAmTdP//QCGPTSzZozwMqZSI wAMCXMcVJrplpyuB/4CYLhRHN0ig0pvf8ATIv6qD6DTX9fYjf2DI6YXIJnit5vk5 q/Rn36/sOcQIFZOCjOX0B32w1lNVJP3NqGRbQvCPSL2j/ouK2yZKk/nlOiV0xT5l 1pf6Ww4z1JcUUzjZpGKvy+mY26Da7pbzIWG8EkoPYefqr/GHBRK/yxlUNivJRlgi k6K8ncz9HKJ9QT/kZVoZuQuRs6W9JGL4SHboQaTUWqhAYg7gsyq/uUaB5S4o6Xs= =a332 -----END PGP SIGNATURE----- --pN9MePJoZbRKbUk1--