From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com
Cc: netdev@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de,
vkuznets@redhat.com, linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH net-next] hv_netvsc: Increase delay for RNDIS_STATUS_NETWORK_CHANGE
Date: Tue, 09 Feb 2016 05:04:38 -0500 (EST) [thread overview]
Message-ID: <20160209.050438.1204672612521151525.davem@davemloft.net> (raw)
In-Reply-To: <1454458556-10591-1-git-send-email-haiyangz@microsoft.com>
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Tue, 2 Feb 2016 16:15:56 -0800
> We simulates a link down period for RNDIS_STATUS_NETWORK_CHANGE message to
> trigger DHCP renew. User daemons may need multiple seconds to trigger the
> link down event. (e.g. ifplugd: 5sec, network-manager: 4sec.) So update
> this link down period to 10 sec to properly trigger DHCP renew.
>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Two things look really bad about this to me:
1) Any value you choose is arbitrary. If some new network configuration daemon
is slower, you will have to change this value again.
This is _NOT_ sustainable in the long term.
2) It is completely unclear to me why this driver needs to delay at all or
wait for anything. I see no other driver having to deal with this issue.
Until you address both of these points I am not going to apply this patch.
Thanks.
next prev parent reply other threads:[~2016-02-09 10:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 0:15 Haiyang Zhang
2016-02-03 13:05 ` Vitaly Kuznetsov
2016-02-03 15:46 ` Haiyang Zhang
2016-02-03 16:06 ` Vitaly Kuznetsov
2016-02-03 16:39 ` Haiyang Zhang
2016-02-09 10:04 ` David Miller [this message]
2016-02-09 15:31 ` Haiyang Zhang
2016-02-16 20:28 ` David Miller
2016-02-17 12:53 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209.050438.1204672612521151525.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®